Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support workspace dependencies #2107

Closed
phated opened this issue Aug 1, 2023 · 0 comments
Closed

Support workspace dependencies #2107

phated opened this issue Aug 1, 2023 · 0 comments
Labels
discussion enhancement New feature or request nargo Noir's CLI development tool

Comments

@phated
Copy link
Contributor

phated commented Aug 1, 2023

Problem

Currently, all dependencies specified in the Nargo.toml must have a "package"-style Nargo.toml at their root. However, we should also support workspace dependencies.

I've done a prototype at https://github.com/noir-lang/noir/tree/phated/workspace-as-dependencies but it's a breaking change and we need to make sure we are okay with the assumptions: it requires that the dependency name match the name field in the Nargo.toml and we'd need something like a package field to allow the dependency to be aliased (also done in that branch).

Happy Case

A user can depend upon a dependency that has a "workspace"-style Nargo.toml at the root of the project and then they can depend upon individual packages from the workspace.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

Yes

Support Needs

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement New feature or request nargo Noir's CLI development tool
Projects
Archived in project
Development

No branches or pull requests

4 participants