Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add executeSync function to acvm_js #3084

Closed
Tracked by #3079
TomAFrench opened this issue Oct 10, 2023 · 1 comment
Closed
Tracked by #3079

Add executeSync function to acvm_js #3084

TomAFrench opened this issue Oct 10, 2023 · 1 comment
Labels
enhancement New feature or request js Noir's JavaScript packages

Comments

@TomAFrench
Copy link
Member

Currently executing Noir programs in acvm_js is asynchronous due to the need to account for foreign calls. This is unhelpful for situations such as in #3079 where we know the circuit doesn't execute any foreign calls.

To address this we can expose an executeSync method which will execute an ACIR program but will just error on any foreign calls.
@TomAFrench TomAFrench mentioned this issue Oct 10, 2023
Closed
@Savio-Sou Savio-Sou added enhancement New feature or request js Noir's JavaScript packages labels Oct 10, 2023
@Savio-Sou
Copy link
Collaborator

Savio-Sou commented Dec 4, 2023 •
edited
Loading

Is this still relevant alongside #3348?

@kevaundray kevaundray closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request js Noir's JavaScript packages
Projects
Noir
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TomAFrench @kevaundray @Savio-Sou