Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove warnings field from DebugArtifact #5118

Merged
merged 3 commits into from
May 28, 2024

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

I'm not sure why the SSA warnings were ever added onto the DebugArtifact but we don't use it at all so we can just remove them (which avoids a dependency on noirc_evaluator)

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@jfecher jfecher added this pull request to the merge queue May 28, 2024
Merged via the queue into master with commit 33c2b6b May 28, 2024
45 checks passed
@jfecher jfecher deleted the tf/remove-warnings-from-debug-artifact branch May 28, 2024 16:23
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request May 28, 2024
…ir#5109)

feat: Sync from aztec-packages (noir-lang/noir#5125)
chore: remove warnings field from `DebugArtifact` (noir-lang/noir#5118)
feat: make ACVM generic across fields (noir-lang/noir#5114)
fix: Auto dereference trait methods in the elaborator (noir-lang/noir#5124)
chore: perform dead instruction elimination through `std::as_witness` (noir-lang/noir#5123)
TomAFrench added a commit to AztecProtocol/aztec-packages that referenced this pull request May 28, 2024
Automated pull of development from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore: deduplicate `ReturnConstant` warning
(noir-lang/noir#5109)
feat: Sync from aztec-packages
(noir-lang/noir#5125)
chore: remove warnings field from `DebugArtifact`
(noir-lang/noir#5118)
feat: make ACVM generic across fields
(noir-lang/noir#5114)
fix: Auto dereference trait methods in the elaborator
(noir-lang/noir#5124)
chore: perform dead instruction elimination through `std::as_witness`
(noir-lang/noir#5123)
END_COMMIT_OVERRIDE

---------

Co-authored-by: TomAFrench <tom@tomfren.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants