Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deduplicate ReturnConstant warning #5109

Merged
merged 1 commit into from
May 28, 2024
Merged

chore: deduplicate ReturnConstant warning #5109

merged 1 commit into from
May 28, 2024

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

This PR inlines flatten_value_list into define_result_var and deduplicates any InternalWarning::ReturnConstant warnings

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench added this pull request to the merge queue May 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 28, 2024
@TomAFrench TomAFrench added this pull request to the merge queue May 28, 2024
Merged via the queue into master with commit a289404 May 28, 2024
44 checks passed
@TomAFrench TomAFrench deleted the tf/inline-flatten-value-list branch May 28, 2024 16:30
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request May 28, 2024
@AztecBot
[1 changes] chore: deduplicate ReturnConstant warning (noir-lang/no…
647598e 
…ir#5109)

feat: Sync from aztec-packages (noir-lang/noir#5125)
chore: remove warnings field from `DebugArtifact` (noir-lang/noir#5118)
feat: make ACVM generic across fields (noir-lang/noir#5114)
fix: Auto dereference trait methods in the elaborator (noir-lang/noir#5124)
chore: perform dead instruction elimination through `std::as_witness` (noir-lang/noir#5123)
@AztecBot AztecBot mentioned this pull request May 28, 2024
Merged
@TomAFrench TomAFrench mentioned this pull request May 28, 2024
Closed
TomAFrench added a commit to AztecProtocol/aztec-packages that referenced this pull request May 28, 2024
@AztecBot @TomAFrench
feat: Sync from noir (#6717)
a37895c 
Automated pull of development from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore: deduplicate `ReturnConstant` warning
(noir-lang/noir#5109)
feat: Sync from aztec-packages
(noir-lang/noir#5125)
chore: remove warnings field from `DebugArtifact`
(noir-lang/noir#5118)
feat: make ACVM generic across fields
(noir-lang/noir#5114)
fix: Auto dereference trait methods in the elaborator
(noir-lang/noir#5124)
chore: perform dead instruction elimination through `std::as_witness`
(noir-lang/noir#5123)
END_COMMIT_OVERRIDE

---------

Co-authored-by: TomAFrench <tom@tomfren.ch>
@AztecBot AztecBot mentioned this pull request May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomAFrench @jfecher