Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl+A highlights almost everything in login screen #31

Closed
guihkx opened this issue Apr 11, 2018 · 4 comments
Closed

Ctrl+A highlights almost everything in login screen #31

guihkx opened this issue Apr 11, 2018 · 4 comments

Comments

@guihkx
Copy link

guihkx commented Apr 11, 2018

Minor issue... Whenever I press Ctrl+A in the login screen, this happens:

https://i.imgur.com/GbLCYmb.jpg (normal: https://i.imgur.com/8Qg3hSO.jpg)

IMHO, nothing should be highlighted when you press Ctrl+A (except user input)

My system:
Arch Linux 64-bit
lightdm-webkit-theme-aether 2.0.1-1
@NoiSek
Copy link
Owner

NoiSek commented Apr 15, 2018

I think that this is probably the expected, if unfortunate, behavior when pressing Ctrl+A outside of an input field.

That said, I'll add a feature in the next release to detect that key combo and focus / highlight the user input, if possible.

@guihkx
Copy link
Author

guihkx commented Apr 15, 2018

Thanks! I don't have much knowledge about CSS but wouldn't it be possible to apply user-select: none to all elements, except inputs?

@NoiSek
Copy link
Owner

NoiSek commented Apr 15, 2018

It's possible to make sure that no element shows the"highlighted" styling with that, but I'm not entirely sure that you can force-select the contents of an input.

i.e. for a user that does Ctrl+A outside of the password field accidentally it would be strange if it highlighted nothing AND it didn't select the password field text

@guihkx
Copy link
Author

guihkx commented Apr 15, 2018 •
edited
Loading

I see... Well, I've been fiddling with the index.html file and I've achieved the behavior I wanted by simply adding the noselect class to the <html> element. Ctrl+A still works, but only when the focus is on the password field. Anyway, that's probably not the behavior you're looking for, so it's totally fine for me if you don't change it. 😝

I've also added draggable=false to all <img> elements. That didn't work. But adding img { -webkit-user-drag: none } to the CSS file does work. Don't ask me why I made those changes, I just don't like stuff being dragged and selected I guess. lol

(Feel free to close this if you want)

@NoiSek NoiSek closed this as completed in 2286031 May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@guihkx @NoiSek