You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The soft launch absolute timing setting allows for negative advance values (S08 in the ini) however correctionSoftLaunch() uses a byte to store the temporary value.
Need to review all ignition corrections functions to make sure the same problem is not happening elsewhere
The text was updated successfully, but these errors were encountered:
The soft launch absolute timing setting allows for negative advance values (S08 in the ini) however correctionSoftLaunch() uses a byte to store the temporary value.
PR #1207 covers this case: the code works correctly as-is.
Need to review all ignition corrections functions to make sure the same problem is not happening elsewhere
I have a follow up PR ready to go that does exactly that (along with a huge speedup).
The soft launch absolute timing setting allows for negative advance values (S08 in the ini) however
correctionSoftLaunch()
uses a byte to store the temporary value.Need to review all ignition corrections functions to make sure the same problem is not happening elsewhere
The text was updated successfully, but these errors were encountered: