Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soft Launch ignition absolute timing is unsigned #1188

Open
noisymime opened this issue Feb 27, 2024 · 1 comment
Open

Soft Launch ignition absolute timing is unsigned #1188

noisymime opened this issue Feb 27, 2024 · 1 comment
Assignees
Labels

Comments

@noisymime
Copy link
Collaborator

The soft launch absolute timing setting allows for negative advance values (S08 in the ini) however correctionSoftLaunch() uses a byte to store the temporary value.

Need to review all ignition corrections functions to make sure the same problem is not happening elsewhere

@noisymime noisymime added the bug label Feb 27, 2024
@noisymime noisymime self-assigned this Feb 27, 2024
@adbancroft
Copy link
Collaborator

The soft launch absolute timing setting allows for negative advance values (S08 in the ini) however correctionSoftLaunch() uses a byte to store the temporary value.

PR #1207 covers this case: the code works correctly as-is.

Need to review all ignition corrections functions to make sure the same problem is not happening elsewhere

I have a follow up PR ready to go that does exactly that (along with a huge speedup).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants