Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon and graphic scaling is broken #20

Closed
hubdot opened this issue May 13, 2021 · 4 comments
Closed

Icon and graphic scaling is broken #20

hubdot opened this issue May 13, 2021 · 4 comments
Assignees
Labels
Category: Bug Fix The issue requires a bug fix Priority: Medium

Comments

@hubdot
Copy link

hubdot commented May 13, 2021

After installing Mikio and enabling it the theme icons get shown at maximum size and don't get scaled. Tested various browsers (Edge, Firefox etc.) with the same effect.

Picture of how it looks: https://i.imgur.com/He8uBAQ.png

@hubdot
Copy link
Author

hubdot commented May 14, 2021

Update: it's resolved if switched to useLESS "checked" in Admin > Configuration Settings
"tpl»mikio»useLESS
Use the LESS compiler for the mikio stylesheet or direct CSS. Requires PHP ctype extensions installed"

I have discovered some other issues but will create new issues for those.

@hubdot hubdot closed this as completed May 14, 2021
@nomadjimbob
Copy link
Owner

I'm going to reopen as the scaling of graphics should not happen regardless of this setting. If your version of PHP does not have the ctype library installed, then it should always revert to not using LESS.

I'll look further into why this was not the case for you.

@nomadjimbob nomadjimbob reopened this May 17, 2021
@nomadjimbob nomadjimbob self-assigned this May 17, 2021
@nomadjimbob nomadjimbob added Category: Bug Fix The issue requires a bug fix Priority: Medium labels May 17, 2021
@nomadjimbob
Copy link
Owner

nomadjimbob commented May 17, 2021

Mikioplugin also uses a LESS formatter that supports PHP versions that does not have ctype extensions installed. For some reason, this was never back-added to the Mikio theme.

I have now pulled that code and made it into its own repository and will add it into Mikio which will support fixes for some of the currently open issues.

@nomadjimbob
Copy link
Owner

polyfill-ctype library is now used and referenced in the LESS code. The commit 692c64c also adds support for symbolic links and supports a fall back to the mikio.css asset instead of no stylesheet at all.

Mikio admin will also now display a message is LESS is not supported on your server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug Fix The issue requires a bug fix Priority: Medium
Projects
None yet
Development

No branches or pull requests

2 participants