Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read spells_us.txt from game directory #55

Open
That-one-Joe opened this issue Dec 9, 2022 · 1 comment
Open

Read spells_us.txt from game directory #55

That-one-Joe opened this issue Dec 9, 2022 · 1 comment
Labels
await-user-response The issue is ready to be closed, pending the user response/confirmation. wontfix This will not be worked on

Comments

@That-one-Joe
Copy link

That-one-Joe commented Dec 9, 2022

Reading the spells_us.txt from the game directory would mean that the correct timings would be used automatically.
I do not see any advantage of this file being in this project; it can possibly only use wrong timings which led me to create this issue - but maybe I am missing something why it was done this way.

https://github.com/nomns/nparse/blob/master/parsers/spells.py#L478 is the location for the change.

I propose changing eq_log_dir in the config to eq_dir generally, automatically appending Logs for the log reading and using this in spells.py for reading spells_us.txt.

@rm-you
Copy link
Collaborator

rm-you commented Apr 15, 2024

There are a lot of custom changes that have been made to that file to actually make things work correctly in-era and with certain features. It would just exhibit many other issues if this were done. Out of curiosity, are you on P99, TLP, or some other server? @That-one-Joe

@rm-you rm-you added wontfix This will not be worked on await-user-response The issue is ready to be closed, pending the user response/confirmation. labels Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
await-user-response The issue is ready to be closed, pending the user response/confirmation. wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants