Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFS on syscall error should log the operation info and not just the error code (even if debug level is low) #8065

Closed
guymguym opened this issue May 22, 2024 · 3 comments · Fixed by #8149
Assignees
Milestone

Comments

@guymguym
Copy link
Member

Environment info

  • NooBaa Version: 5.15.3
  • Platform: rhel

Actual behavior

  1. on syscall error we only see the err code unless we turn on higher debug log -
May 21 16:19:48 host node[2941584]: May-21 16:19:48.654 [nsfs/2941584] [ERROR] core.sdk.namespace_fs::  [Error: Operation not permitted] { code: 'EPERM' }

Expected behavior

  1. Should log the operation info with the error code.

Steps to reproduce

  1. Change fs permissions to cause EPERM.
@guymguym
Copy link
Member Author

CC @romayalon @eshelmarc

@tangledbytes
Copy link
Member

tangledbytes commented Jun 3, 2024

@guymguym trying to understand this issue. What is the desired behaviour?

  1. fs_napi should log the context of the error but the error that is bubbled up is still what we get out of errno conversion?
  2. fs_napi should modify the reported error, i.e it should append or prepend the context info with the translated error and then report that to JS layer? This will then appear whenever JS layer throws the error?
  3. Or something completely different?

@guymguym
Copy link
Member Author

guymguym commented Jun 3, 2024

@tangledbytes I think that option 2 is best if possible, but in any case I would anway do option 1 and log the error context in fs_napi to make sure we have it in the logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants