Skip to content

Commit

Permalink
#7154 Renamed AccessDeniedDataTablesJson method to AccessDeniedJsonAsync
Browse files Browse the repository at this point in the history
  • Loading branch information
skoshelev committed May 17, 2024
1 parent 6a4aab8 commit a60580d
Show file tree
Hide file tree
Showing 67 changed files with 300 additions and 300 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ public async Task<IActionResult> RevokeAccess()
public async Task<IActionResult> SyncRecordList(SyncRecordSearchModel searchModel)
{
if (!await _permissionService.AuthorizeAsync(StandardPermissionProvider.ManagePlugins))
return await AccessDeniedDataTablesJson();
return await AccessDeniedJsonAsync();

var records = await _zettleRecordService.GetAllRecordsAsync(productOnly: true,
pageIndex: searchModel.Page - 1, pageSize: searchModel.PageSize);
Expand Down Expand Up @@ -367,7 +367,7 @@ public async Task<IActionResult> SyncRecordList(SyncRecordSearchModel searchMode
public async Task<IActionResult> SyncRecordUpdate(SyncRecordModel model)
{
if (!await _permissionService.AuthorizeAsync(StandardPermissionProvider.ManagePlugins))
return await AccessDeniedDataTablesJson();
return await AccessDeniedJsonAsync();

var productRecord = await _zettleRecordService.GetRecordByIdAsync(model.Id)
?? throw new ArgumentException("No record found");
Expand All @@ -390,7 +390,7 @@ public async Task<IActionResult> SyncRecordUpdate(SyncRecordModel model)
public async Task<IActionResult> SyncRecordDelete(ICollection<int> selectedIds)
{
if (!await _permissionService.AuthorizeAsync(StandardPermissionProvider.ManagePlugins))
return await AccessDeniedDataTablesJson();
return await AccessDeniedJsonAsync();

if (!selectedIds?.Any() ?? true)
return NoContent();
Expand Down Expand Up @@ -431,10 +431,10 @@ public async Task<IActionResult> ProductToSync()
public async Task<IActionResult> ProductListToSync(AddProductToSyncSearchModel searchModel)
{
if (!await _permissionService.AuthorizeAsync(StandardPermissionProvider.ManagePlugins))
return await AccessDeniedDataTablesJson();
return await AccessDeniedJsonAsync();

if (!await _permissionService.AuthorizeAsync(StandardPermissionProvider.ManageProducts))
return await AccessDeniedDataTablesJson();
return await AccessDeniedJsonAsync();

var products = await _productService.SearchProductsAsync(showHidden: true,
keywords: searchModel.SearchProductName,
Expand Down Expand Up @@ -487,7 +487,7 @@ public async Task<IActionResult> ProductToSync(AddProductToSyncModel model)
public async Task<IActionResult> SyncStart()
{
if (!await _permissionService.AuthorizeAsync(StandardPermissionProvider.ManagePlugins))
return await AccessDeniedDataTablesJson();
return await AccessDeniedJsonAsync();

await _zettleService.ImportAsync();

Expand All @@ -497,7 +497,7 @@ public async Task<IActionResult> SyncStart()
public async Task<IActionResult> SyncUpdate()
{
if (!await _permissionService.AuthorizeAsync(StandardPermissionProvider.ManagePlugins))
return await AccessDeniedDataTablesJson();
return await AccessDeniedJsonAsync();

if (string.IsNullOrEmpty(_zettleSettings.ImportId))
return ErrorJson("Synchronization not found");
Expand Down
2 changes: 1 addition & 1 deletion src/Plugins/Nop.Plugin.Misc.Zettle/plugin.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"Group": "Misc",
"FriendlyName": "PayPal Zettle",
"SystemName": "Misc.Zettle",
"Version": "4.70.7",
"Version": "4.70.8",
"SupportedVersions": [ "4.70" ],
"Author": "nopCommerce team",
"DisplayOrder": 1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ public async Task<IActionResult> Configure(ConfigurationModel model)
public async Task<IActionResult> GoogleAuthenticatorList(GoogleAuthenticatorSearchModel searchModel)
{
if (!await _permissionService.AuthorizeAsync(StandardPermissionProvider.ManageMultifactorAuthenticationMethods))
return await AccessDeniedDataTablesJson();
return await AccessDeniedJsonAsync();

//get GoogleAuthenticator configuration records
var configurations = await _googleAuthenticatorService.GetPagedConfigurationsAsync(searchModel.SearchEmail,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"Group": "Multi-factor authentication",
"FriendlyName": "Google Authenticator",
"SystemName": "MultiFactorAuth.GoogleAuthenticator",
"Version": "4.70.4",
"Version": "4.70.5",
"SupportedVersions": [ "4.70" ],
"Author": "nopCommerce team",
"DisplayOrder": 1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public async Task<IActionResult> Configure()
public async Task<IActionResult> List(StorePickupPointSearchModel searchModel)
{
if (!await _permissionService.AuthorizeAsync(StandardPermissionProvider.ManageShippingSettings))
return await AccessDeniedDataTablesJson();
return await AccessDeniedJsonAsync();

//prepare model
var model = await _storePickupPointModelFactory.PrepareStorePickupPointListModelAsync(searchModel);
Expand Down Expand Up @@ -262,7 +262,7 @@ public async Task<IActionResult> Edit(StorePickupPointModel model)
public async Task<IActionResult> Delete(int id)
{
if (!await _permissionService.AuthorizeAsync(StandardPermissionProvider.ManageShippingSettings))
return await AccessDeniedDataTablesJson();
return await AccessDeniedJsonAsync();

var pickupPoint = await _storePickupPointService.GetStorePickupPointByIdAsync(id);
if (pickupPoint == null)
Expand Down
2 changes: 1 addition & 1 deletion src/Plugins/Nop.Plugin.Pickup.PickupInStore/plugin.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"Group": "Pickup points",
"FriendlyName": "Pickup in store",
"SystemName": "Pickup.PickupInStore",
"Version": "4.70.6",
"Version": "4.70.7",
"SupportedVersions": [ "4.70" ],
"Author": "nopCommerce team",
"DisplayOrder": 1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ public async Task<IActionResult> SaveMode(bool value)
public async Task<IActionResult> FixedShippingRateList(ConfigurationModel searchModel)
{
if (!await _permissionService.AuthorizeAsync(StandardPermissionProvider.ManageShippingSettings))
return await AccessDeniedDataTablesJson();
return await AccessDeniedJsonAsync();

var shippingMethods = (await _shippingService.GetAllShippingMethodsAsync()).ToPagedList(searchModel);

Expand Down Expand Up @@ -207,7 +207,7 @@ public async Task<IActionResult> UpdateFixedShippingRate(FixedRateModel model)
public async Task<IActionResult> RateByWeightByTotalList(ConfigurationModel searchModel, ConfigurationModel filter)
{
if (!await _permissionService.AuthorizeAsync(StandardPermissionProvider.ManageShippingSettings))
return await AccessDeniedDataTablesJson();
return await AccessDeniedJsonAsync();

//var records = _shippingByWeightService.GetAll(command.Page - 1, command.PageSize);
var records = await _shippingByWeightService.FindRecordsAsync(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"Group": "Shipping rate computation",
"FriendlyName": "Manual (Fixed or By Weight and By Total)",
"SystemName": "Shipping.FixedByWeightByTotal",
"Version": "4.70.7",
"Version": "4.70.8",
"SupportedVersions": [ "4.70" ],
"Author": "nopCommerce team",
"DisplayOrder": 1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ public override async Task<IActionResult> Categories(TaxCategorySearchModel sear
return await base.Categories(searchModel);

if (!await _permissionService.AuthorizeAsync(StandardPermissionProvider.ManageTaxSettings))
return await AccessDeniedDataTablesJson();
return await AccessDeniedJsonAsync();

//get tax categories
var taxCategories = (await _taxCategoryService.GetAllTaxCategoriesAsync()).ToPagedList(searchModel);
Expand Down Expand Up @@ -155,7 +155,7 @@ public async Task<IActionResult> TaxCategoryAdd(Models.Tax.TaxCategoryModel mode
return new NullJsonResult();

if (!await _permissionService.AuthorizeAsync(StandardPermissionProvider.ManageTaxSettings))
return await AccessDeniedDataTablesJson();
return await AccessDeniedJsonAsync();

if (!ModelState.IsValid)
return ErrorJson(ModelState.SerializeErrors());
Expand All @@ -179,7 +179,7 @@ public override async Task<IActionResult> CategoryDelete(int id)
return new NullJsonResult();

if (!await _permissionService.AuthorizeAsync(StandardPermissionProvider.ManageTaxSettings))
return await AccessDeniedDataTablesJson();
return await AccessDeniedJsonAsync();

//try to get a tax category with the specified id
var taxCategory = await _taxCategoryService.GetTaxCategoryByIdAsync(id)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public ItemClassificationController(AvalaraTaxManager avalaraTaxManager,
public async Task<IActionResult> List(ItemClassificationSearchModel searchModel)
{
if (!await _permissionService.AuthorizeAsync(StandardPermissionProvider.ManageTaxSettings))
return await AccessDeniedDataTablesJson();
return await AccessDeniedJsonAsync();

//get item classification
var itemClassification = await _itemClassificationService.GetItemClassificationAsync(
Expand Down Expand Up @@ -100,7 +100,7 @@ public async Task<IActionResult> List(ItemClassificationSearchModel searchModel)
public async Task<IActionResult> Update(ItemClassificationModel model)
{
if (!await _permissionService.AuthorizeAsync(StandardPermissionProvider.ManageTaxSettings))
return await AccessDeniedDataTablesJson();
return await AccessDeniedJsonAsync();

var item = await _itemClassificationService.GetItemClassificationByIdAsync(model.Id)
?? throw new ArgumentException("No record found");
Expand All @@ -116,7 +116,7 @@ public async Task<IActionResult> Update(ItemClassificationModel model)
public async Task<IActionResult> DeleteSelected(List<int> selectedIds)
{
if (!await _permissionService.AuthorizeAsync(StandardPermissionProvider.ManageTaxSettings))
return await AccessDeniedDataTablesJson();
return await AccessDeniedJsonAsync();

if (!selectedIds?.Any() ?? true)
return NoContent();
Expand All @@ -139,7 +139,7 @@ public async Task<IActionResult> DeleteSelected(List<int> selectedIds)
public async Task<IActionResult> ClearAll()
{
if (!await _permissionService.AuthorizeAsync(StandardPermissionProvider.ManageTaxSettings))
return await AccessDeniedDataTablesJson();
return await AccessDeniedJsonAsync();

await _itemClassificationService.ClearItemClassificationAsync();

Expand Down Expand Up @@ -169,10 +169,10 @@ public async Task<IActionResult> ProductToClassification()
public async Task<IActionResult> ProductListToClassification(AddProductToClassificationSearchModel searchModel)
{
if (!await _permissionService.AuthorizeAsync(StandardPermissionProvider.ManageTaxSettings))
return await AccessDeniedDataTablesJson();
return await AccessDeniedJsonAsync();

if (!await _permissionService.AuthorizeAsync(StandardPermissionProvider.ManageProducts))
return await AccessDeniedDataTablesJson();
return await AccessDeniedJsonAsync();

var products = await _productService.SearchProductsAsync(showHidden: true,
keywords: searchModel.SearchProductName,
Expand Down Expand Up @@ -218,7 +218,7 @@ public async Task<IActionResult> ProductToClassification(AddProductToClassificat
public async Task<IActionResult> StartClassification()
{
if (!await _permissionService.AuthorizeAsync(StandardPermissionProvider.ManageTaxSettings))
return await AccessDeniedDataTablesJson();
return await AccessDeniedJsonAsync();

var items = (await _itemClassificationService.GetItemClassificationAsync())
.Where(x => string.IsNullOrEmpty(x.HSClassificationRequestId))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public TaxTransactionLogController(ICustomerService customerService,
public async Task<IActionResult> LogList(TaxTransactionLogSearchModel searchModel)
{
if (!await _permissionService.AuthorizeAsync(StandardPermissionProvider.ManageTaxSettings))
return await AccessDeniedDataTablesJson();
return await AccessDeniedJsonAsync();

//prepare filter parameters
var createdFromValue = searchModel.CreatedFrom.HasValue
Expand Down Expand Up @@ -87,7 +87,7 @@ public async Task<IActionResult> LogList(TaxTransactionLogSearchModel searchMode
public async Task<IActionResult> DeleteSelected(ICollection<int> selectedIds)
{
if (!await _permissionService.AuthorizeAsync(StandardPermissionProvider.ManageTaxSettings))
return await AccessDeniedDataTablesJson();
return await AccessDeniedJsonAsync();

if (selectedIds == null || !selectedIds.Any())
return NoContent();
Expand Down Expand Up @@ -142,7 +142,7 @@ public async Task<IActionResult> Delete(int id)
public async Task<IActionResult> ClearAll()
{
if (!await _permissionService.AuthorizeAsync(StandardPermissionProvider.ManageTaxSettings))
return await AccessDeniedDataTablesJson();
return await AccessDeniedJsonAsync();

await _taxTransactionLogService.ClearLogAsync();

Expand Down
2 changes: 1 addition & 1 deletion src/Plugins/Nop.Plugin.Tax.Avalara/plugin.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"Group": "Tax providers",
"FriendlyName": "Avalara tax provider",
"SystemName": "Tax.Avalara",
"Version": "4.70.10",
"Version": "4.70.11",
"SupportedVersions": [ "4.70" ],
"Author": "nopCommerce team",
"DisplayOrder": 1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ public async Task<IActionResult> SaveMode(bool value)
public async Task<IActionResult> FixedRatesList(ConfigurationModel searchModel)
{
if (!await _permissionService.AuthorizeAsync(StandardPermissionProvider.ManageTaxSettings))
return await AccessDeniedDataTablesJson();
return await AccessDeniedJsonAsync();

var categories = (await _taxCategoryService.GetAllTaxCategoriesAsync()).ToPagedList(searchModel);

Expand Down Expand Up @@ -189,7 +189,7 @@ public async Task<IActionResult> FixedRateUpdate(FixedTaxRateModel model)
public async Task<IActionResult> RatesByCountryStateZipList(ConfigurationModel searchModel)
{
if (!await _permissionService.AuthorizeAsync(StandardPermissionProvider.ManageTaxSettings))
return await AccessDeniedDataTablesJson();
return await AccessDeniedJsonAsync();

var records = await _taxRateService.GetAllTaxRatesAsync(searchModel.Page - 1, searchModel.PageSize);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"Group": "Tax providers",
"FriendlyName": "Manual (Fixed or By Country/State/Zip)",
"SystemName": "Tax.FixedOrByCountryStateZip",
"Version": "4.70.5",
"Version": "4.70.6",
"SupportedVersions": [ "4.70" ],
"Author": "nopCommerce team",
"DisplayOrder": 1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ public async Task<IActionResult> Configure()
public virtual async Task<IActionResult> List(FacebookPixelSearchModel searchModel)
{
if (!await _permissionService.AuthorizeAsync(StandardPermissionProvider.ManageWidgets))
return await AccessDeniedDataTablesJson();
return await AccessDeniedJsonAsync();

var configurations = await _facebookPixelService.GetPagedConfigurationsAsync(searchModel.StoreId, searchModel.Page - 1, searchModel.PageSize);
var model = await new FacebookPixelListModel().PrepareToGridAsync(searchModel, configurations, () =>
Expand Down Expand Up @@ -263,7 +263,7 @@ public virtual async Task<IActionResult> Delete(int id)
public virtual async Task<IActionResult> CustomEventList(CustomEventSearchModel searchModel)
{
if (!await _permissionService.AuthorizeAsync(StandardPermissionProvider.ManageWidgets))
return await AccessDeniedDataTablesJson();
return await AccessDeniedJsonAsync();

var configuration = await _facebookPixelService.GetConfigurationByIdAsync(searchModel.ConfigurationId)
?? throw new ArgumentException("No configuration found with the specified id", nameof(searchModel.ConfigurationId));
Expand All @@ -288,7 +288,7 @@ public virtual async Task<IActionResult> CustomEventList(CustomEventSearchModel
public virtual async Task<IActionResult> CustomEventAdd(int configurationId, [Validate] CustomEventModel model)
{
if (!await _permissionService.AuthorizeAsync(StandardPermissionProvider.ManageWidgets))
return await AccessDeniedDataTablesJson();
return await AccessDeniedJsonAsync();

if (!ModelState.IsValid)
return ErrorJson(ModelState.SerializeErrors());
Expand All @@ -303,7 +303,7 @@ public virtual async Task<IActionResult> CustomEventAdd(int configurationId, [Va
public virtual async Task<IActionResult> CustomEventDelete(int configurationId, string id)
{
if (!await _permissionService.AuthorizeAsync(StandardPermissionProvider.ManageWidgets))
return await AccessDeniedDataTablesJson();
return await AccessDeniedJsonAsync();

//save custom events configuration
var eventName = id;
Expand All @@ -315,7 +315,7 @@ public virtual async Task<IActionResult> CustomEventDelete(int configurationId,
public async Task<IActionResult> CookieSettingsWarning(bool disableForUsersNotAcceptingCookieConsent)
{
if (!await _permissionService.AuthorizeAsync(StandardPermissionProvider.ManageWidgets))
return await AccessDeniedDataTablesJson();
return await AccessDeniedJsonAsync();

if (!disableForUsersNotAcceptingCookieConsent || _storeInformationSettings.DisplayEuCookieLawWarning)
return Json(new { Result = string.Empty });
Expand Down
2 changes: 1 addition & 1 deletion src/Plugins/Nop.Plugin.Widgets.FacebookPixel/plugin.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"Group": "Widgets",
"FriendlyName": "Facebook Pixel",
"SystemName": "Widgets.FacebookPixel",
"Version": "4.70.7",
"Version": "4.70.8",
"SupportedVersions": [ "4.70" ],
"Author": "nopCommerce team",
"DisplayOrder": 1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -222,13 +222,13 @@ protected virtual IActionResult AccessDeniedView()
}

/// <summary>
/// Access denied JSON data for DataTables
/// Access denied JSON data
/// </summary>
/// <returns>
/// A task that represents the asynchronous operation
/// The task result contains the access denied JSON data
/// </returns>
protected virtual async Task<JsonResult> AccessDeniedDataTablesJson()
protected virtual async Task<JsonResult> AccessDeniedJsonAsync()
{
var localizationService = EngineContext.Current.Resolve<ILocalizationService>();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ public virtual async Task<IActionResult> ActivityLogs()
public virtual async Task<IActionResult> ListLogs(ActivityLogSearchModel searchModel)
{
if (!await _permissionService.AuthorizeAsync(StandardPermissionProvider.ManageActivityLog))
return await AccessDeniedDataTablesJson();
return await AccessDeniedJsonAsync();

//prepare model
var model = await _activityLogModelFactory.PrepareActivityLogListModelAsync(searchModel);
Expand All @@ -107,7 +107,7 @@ public virtual async Task<IActionResult> ListLogs(ActivityLogSearchModel searchM
public virtual async Task<IActionResult> ActivityLogDelete(int id)
{
if (!await _permissionService.AuthorizeAsync(StandardPermissionProvider.ManageActivityLog))
return await AccessDeniedDataTablesJson();
return await AccessDeniedJsonAsync();

//try to get a log item with the specified id
var logItem = await _customerActivityService.GetActivityByIdAsync(id)
Expand Down
Loading

0 comments on commit a60580d

Please sign in to comment.