Skip to content

Commit

Permalink
#148 Further changes on "Performance. We should remove only appropria…
Browse files Browse the repository at this point in the history 
…te records from cache when some event is triggered (not all ones)"
  • Loading branch information
@AndreiMaz
AndreiMaz committed Nov 2, 2016
1 parent 85e5a40 commit bef112c
Showing 1 changed file with 13 additions and 13 deletions.
26 changes: 13 additions & 13 deletions src/Presentation/Nop.Web/Infrastructure/Cache/ModelCacheEventConsumer.cs
View file
Expand Up @@ -199,7 +199,7 @@ public ModelCacheEventConsumer(CatalogSettings catalogSettings)
/// </remarks>
public const string MANUFACTURER_HAS_FEATURED_PRODUCTS_KEY = "Nop.pres.manufacturer.hasfeaturedproducts-{0}-{1}-{2}";
public const string MANUFACTURER_HAS_FEATURED_PRODUCTS_PATTERN_KEY = "Nop.pres.manufacturer.hasfeaturedproducts";
public const string MANUFACTURER_HAS_FEATURED_PRODUCTS_PATTERN_KEY_BY_ID = "Nop.pres.manufacturer.hasfeaturedproducts-{0}";
public const string MANUFACTURER_HAS_FEATURED_PRODUCTS_PATTERN_KEY_BY_ID = "Nop.pres.manufacturer.hasfeaturedproducts-{0}-";

/// <summary>
/// Key for CategoryNavigationModel caching
Expand Down Expand Up @@ -244,7 +244,7 @@ public ModelCacheEventConsumer(CatalogSettings catalogSettings)
/// </remarks>
public const string CATEGORY_HAS_FEATURED_PRODUCTS_KEY = "Nop.pres.category.hasfeaturedproducts-{0}-{1}-{2}";
public const string CATEGORY_HAS_FEATURED_PRODUCTS_PATTERN_KEY = "Nop.pres.category.hasfeaturedproducts";
public const string CATEGORY_HAS_FEATURED_PRODUCTS_PATTERN_KEY_BY_ID = "Nop.pres.category.hasfeaturedproducts-{0}";
public const string CATEGORY_HAS_FEATURED_PRODUCTS_PATTERN_KEY_BY_ID = "Nop.pres.category.hasfeaturedproducts-{0}-";

/// <summary>
/// Key for caching of category breadcrumb
Expand Down Expand Up @@ -315,7 +315,7 @@ public ModelCacheEventConsumer(CatalogSettings catalogSettings)
/// </remarks>
public const string PRODUCT_BREADCRUMB_MODEL_KEY = "Nop.pres.product.breadcrumb-{0}-{1}-{2}-{3}";
public const string PRODUCT_BREADCRUMB_PATTERN_KEY = "Nop.pres.product.breadcrumb";
public const string PRODUCT_BREADCRUMB_PATTERN_KEY_BY_ID = "Nop.pres.product.breadcrumb-{0}";
public const string PRODUCT_BREADCRUMB_PATTERN_KEY_BY_ID = "Nop.pres.product.breadcrumb-{0}-";

/// <summary>
/// Key for ProductTagModel caching
Expand Down Expand Up @@ -349,7 +349,7 @@ public ModelCacheEventConsumer(CatalogSettings catalogSettings)
/// </remarks>
public const string PRODUCT_MANUFACTURERS_MODEL_KEY = "Nop.pres.product.manufacturers-{0}-{1}-{2}-{3}";
public const string PRODUCT_MANUFACTURERS_PATTERN_KEY = "Nop.pres.product.manufacturers";
public const string PRODUCT_MANUFACTURERS_PATTERN_KEY_BY_ID = "Nop.pres.product.manufacturers-{0}";
public const string PRODUCT_MANUFACTURERS_PATTERN_KEY_BY_ID = "Nop.pres.product.manufacturers-{0}-";

/// <summary>
/// Key for ProductSpecificationModel caching
Expand All @@ -360,17 +360,17 @@ public ModelCacheEventConsumer(CatalogSettings catalogSettings)
/// </remarks>
public const string PRODUCT_SPECS_MODEL_KEY = "Nop.pres.product.specs-{0}-{1}";
public const string PRODUCT_SPECS_PATTERN_KEY = "Nop.pres.product.specs";
public const string PRODUCT_SPECS_PATTERN_KEY_BY_ID = "Nop.pres.product.specs-{0}";
public const string PRODUCT_SPECS_PATTERN_KEY_BY_ID = "Nop.pres.product.specs-{0}-";

/// <summary>
/// Key for caching of a value indicating whether a product has product attributes
/// </summary>
/// <remarks>
/// {0} : product id
/// </remarks>
public const string PRODUCT_HAS_PRODUCT_ATTRIBUTES_KEY = "Nop.pres.product.hasproductattributes-{0}";
public const string PRODUCT_HAS_PRODUCT_ATTRIBUTES_KEY = "Nop.pres.product.hasproductattributes-{0}-";
public const string PRODUCT_HAS_PRODUCT_ATTRIBUTES_PATTERN_KEY = "Nop.pres.product.hasproductattributes";
public const string PRODUCT_HAS_PRODUCT_ATTRIBUTES_PATTERN_KEY_BY_ID = "Nop.pres.product.hasproductattributes-{0}";
public const string PRODUCT_HAS_PRODUCT_ATTRIBUTES_PATTERN_KEY_BY_ID = "Nop.pres.product.hasproductattributes-{0}-";

/// <summary>
/// Key for TopicModel caching
Expand Down Expand Up @@ -499,7 +499,7 @@ public ModelCacheEventConsumer(CatalogSettings catalogSettings)
/// </remarks>
public const string PRODUCT_DEFAULTPICTURE_MODEL_KEY = "Nop.pres.product.detailspictures-{0}-{1}-{2}-{3}-{4}-{5}";
public const string PRODUCT_DEFAULTPICTURE_PATTERN_KEY = "Nop.pres.product.detailspictures";
public const string PRODUCT_DEFAULTPICTURE_PATTERN_KEY_BY_ID = "Nop.pres.product.detailspictures-{0}";
public const string PRODUCT_DEFAULTPICTURE_PATTERN_KEY_BY_ID = "Nop.pres.product.detailspictures-{0}-";

/// <summary>
/// Key for product picture caching on the product details page
Expand All @@ -514,7 +514,7 @@ public ModelCacheEventConsumer(CatalogSettings catalogSettings)
/// </remarks>
public const string PRODUCT_DETAILS_PICTURES_MODEL_KEY = "Nop.pres.product.picture-{0}-{1}-{2}-{3}-{4}-{5}";
public const string PRODUCT_DETAILS_PICTURES_PATTERN_KEY = "Nop.pres.product.picture";
public const string PRODUCT_DETAILS_PICTURES_PATTERN_KEY_BY_ID = "Nop.pres.product.picture-{0}";
public const string PRODUCT_DETAILS_PICTURES_PATTERN_KEY_BY_ID = "Nop.pres.product.picture-{0}-";

/// <summary>
/// Key for product reviews caching
Expand All @@ -525,7 +525,7 @@ public ModelCacheEventConsumer(CatalogSettings catalogSettings)
/// </remarks>
public const string PRODUCT_REVIEWS_MODEL_KEY = "Nop.pres.product.reviews-{0}-{1}";
public const string PRODUCT_REVIEWS_PATTERN_KEY = "Nop.pres.product.reviews";
public const string PRODUCT_REVIEWS_PATTERN_KEY_BY_ID = "Nop.pres.product.reviews-{0}";
public const string PRODUCT_REVIEWS_PATTERN_KEY_BY_ID = "Nop.pres.product.reviews-{0}-";

/// <summary>
/// Key for product attribute picture caching on the product details page
Expand Down Expand Up @@ -562,7 +562,7 @@ public ModelCacheEventConsumer(CatalogSettings catalogSettings)
/// </remarks>
public const string CATEGORY_PICTURE_MODEL_KEY = "Nop.pres.category.picture-{0}-{1}-{2}-{3}-{4}-{5}";
public const string CATEGORY_PICTURE_PATTERN_KEY = "Nop.pres.category.picture";
public const string CATEGORY_PICTURE_PATTERN_KEY_BY_ID = "Nop.pres.category.picture-{0}";
public const string CATEGORY_PICTURE_PATTERN_KEY_BY_ID = "Nop.pres.category.picture-{0}-";

/// <summary>
/// Key for manufacturer picture caching
Expand All @@ -577,7 +577,7 @@ public ModelCacheEventConsumer(CatalogSettings catalogSettings)
/// </remarks>
public const string MANUFACTURER_PICTURE_MODEL_KEY = "Nop.pres.manufacturer.picture-{0}-{1}-{2}-{3}-{4}-{5}";
public const string MANUFACTURER_PICTURE_PATTERN_KEY = "Nop.pres.manufacturer.picture";
public const string MANUFACTURER_PICTURE_PATTERN_KEY_BY_ID = "Nop.pres.manufacturer.picture-{0}";
public const string MANUFACTURER_PICTURE_PATTERN_KEY_BY_ID = "Nop.pres.manufacturer.picture-{0}-";

/// <summary>
/// Key for vendor picture caching
Expand All @@ -592,7 +592,7 @@ public ModelCacheEventConsumer(CatalogSettings catalogSettings)
/// </remarks>
public const string VENDOR_PICTURE_MODEL_KEY = "Nop.pres.vendor.picture-{0}-{1}-{2}-{3}-{4}-{5}";
public const string VENDOR_PICTURE_PATTERN_KEY = "Nop.pres.vendor.picture";
public const string VENDOR_PICTURE_PATTERN_KEY_BY_ID = "Nop.pres.vendor.picture-{0}";
public const string VENDOR_PICTURE_PATTERN_KEY_BY_ID = "Nop.pres.vendor.picture-{0}-";

/// <summary>
/// Key for cart picture caching
Expand Down

4 comments on commit bef112c

@m1dst
Copy link

@m1dst m1dst commented on bef112c Nov 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this commit? I don't see any point in having the extra "-"? Can you advise?

@AndreiMaz
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, if ID 1 is passed, then it'll remove everything starting 1 (e.g. 1 and 18)

@m1dst
Copy link

@m1dst m1dst commented on bef112c Nov 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Didn't realise the key was a StartsWith and not Equals. Thanks.

@m1dst
Copy link

@m1dst m1dst commented on bef112c Nov 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess what. I'm dumb. _cacheManager.RemoveByPattern. Thanks again

Please sign in to comment.