Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance. Optimize cache implementation (remove only appropriate records from cache when some event is triggered) #148

Closed
mariannk opened this issue Jan 15, 2016 · 0 comments

Comments

@mariannk
Copy link

mariannk commented Jan 15, 2016

Currently when we cache prices or any models, then we remove all records from the cache (when some event occur). But why not removing only an updated item? For example, there's no need to remove all cached product prices if actually only one product is updated

we sometimes it's almost not possible. for example, PRODUCTS_ALSO_PURCHASED_IDS_KEY. We can remove keys of the current products ({0} parameter). But we should understand that we current product could be part of some other PRODUCTS_ALSO_PURCHASED_IDS_KEY

Actually there's no need to implement it for all entities. We should do it just for entities that could have a lot of records (thousands). For example, anything related to products

also see http://www.nopcommerce.com/boards/t/43931/increase-performance-in-addloacles.aspx#174309

@mariannk mariannk added this to the Version 3.80 milestone Jan 15, 2016
@AndreiMaz AndreiMaz changed the title Optimize cache implementation Optimize cache implementation (remove only appropriate records from cache when some event is triggered) Mar 8, 2016
@AndreiMaz AndreiMaz self-assigned this Mar 8, 2016
@AndreiMaz AndreiMaz removed this from the Version 3.80 milestone Mar 11, 2016
@AndreiMaz AndreiMaz added this to the Version 3.80 milestone Jun 8, 2016
@AndreiMaz AndreiMaz removed this from the Version 3.80 milestone Jul 11, 2016
@AndreiMaz AndreiMaz removed their assignment Jul 11, 2016
@AndreiMaz AndreiMaz modified the milestone: Version 3.90 Jul 28, 2016
@AndreiMaz AndreiMaz self-assigned this Sep 13, 2016
@AndreiMaz AndreiMaz changed the title Optimize cache implementation (remove only appropriate records from cache when some event is triggered) Performance. Optimize cache implementation (remove only appropriate records from cache when some event is triggered) Nov 2, 2016
AndreiMaz added a commit that referenced this issue Nov 2, 2016
…e when some event is triggered (not all ones)
AndreiMaz added a commit that referenced this issue Nov 2, 2016
…e when some event is triggered (not all ones)
AndreiMaz added a commit that referenced this issue Nov 2, 2016
…e when some event is triggered (not all ones)
AndreiMaz added a commit that referenced this issue Nov 2, 2016
…te records from cache when some event is triggered (not all ones)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants