Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MapPath from IWebHelper/WebHelper and call it directly from CommonHelper #1234

Closed
AndreiMaz opened this issue Feb 22, 2016 · 2 comments
Closed

Remove MapPath from IWebHelper/WebHelper and call it directly from CommonHelper #1234

AndreiMaz opened this issue Feb 22, 2016 · 2 comments
Milestone
Version 3.80

Comments

@AndreiMaz
Copy link
Member

Source: http://www.nopcommerce.com/boards/t/40764/mappath.aspx
@AndreiMaz AndreiMaz added this to the Version 3.80 milestone Feb 22, 2016
@schulz3000
Copy link
Contributor

Hi,
I'm interested to get in touch with the code base. Can I take this Issue and try to create a PR?

@AndreiMaz
Copy link
Member Author

Sure, please!

AndreiMaz added a commit that referenced this issue Mar 1, 2016
@AndreiMaz
Merge pull request #1257 from schulz3000/fix_1234
56ea2e3 
 #1234 Removed MapPath from IWebHelper/WebHelper and now we invoke it directly from CommonHelper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 3.80
Development

No branches or pull requests
2 participants
@schulz3000 @AndreiMaz