Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make a [store] as a soft deleted entity #5096

Closed
RomanovM opened this issue Oct 16, 2020 · 2 comments
Closed

Make a [store] as a soft deleted entity #5096

RomanovM opened this issue Oct 16, 2020 · 2 comments
Assignees
@exileDev
Labels
refactoring / source code
Milestone
Version 4.60

Comments

@RomanovM
Copy link
Contributor

RomanovM commented Oct 16, 2020 •
edited

nopCommerce version: develop

Store must implement the ISoftDeletedEntity and just be marked as Deleted when deleted to avoid losing of the related mapping data.

See also: #5035
@RomanovM RomanovM added this to the Version 4.40 milestone Oct 16, 2020
@badijm
Copy link
Contributor

badijm commented Oct 19, 2020 •
edited

Hi, I can work on that, looks simple enough.

Update - I've checked the sources. Looks like we also need to update this razor view. (Admin/Store/Edit/)

image

@badijm badijm mentioned this issue Oct 23, 2020
Closed
@AndreiMaz AndreiMaz changed the title Make Store as a soft deleted entity Make a [store] as a soft deleted entity Dec 8, 2020
@AndreiMaz AndreiMaz modified the milestones: Version 4.40, Version 4.50 Feb 19, 2021
@DmitriyKulagin DmitriyKulagin mentioned this issue Feb 19, 2021
Closed
@RomanovM RomanovM modified the milestones: Version 4.50, Version 4.60 Oct 8, 2021
@AndreiMaz AndreiMaz modified the milestone: Version 4.60 Nov 12, 2021
exileDev added a commit that referenced this issue Aug 26, 2022
@exileDev
#5096 Added implementation of the ISoftDeletedEntity interface to the…
dec19a9 
… Store entity
@exileDev
Copy link
Contributor

Closed #5096

exileDev added a commit that referenced this issue Sep 5, 2022
@exileDev
Merge pull request #6347 from capadong/develop
85f1c0d 
#5096 Skipped running no dependency migrations before DB created
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@exileDev exileDev

Labels
refactoring / source code
Projects
None yet
Milestone
Version 4.60
Development

No branches or pull requests
4 participants
@AndreiMaz @RomanovM @exileDev @badijm