Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix of 5096: Make Store as a soft deleted entity #5110

Closed
wants to merge 2 commits into from
Closed

Fix of 5096: Make Store as a soft deleted entity #5110

wants to merge 2 commits into from

Conversation

badijm
Copy link
Contributor

@badijm badijm commented Oct 23, 2020

Fix of #5096

  • Inherit from ISoftDeletedEntity & add new column on UI, view model & resource file.

@exileDev
Copy link
Contributor

Hi, @badijm! But what about migrations? This issue isn't trivial. The first usage of the Store entity occurs before any migration has run. So we can't run a nopCommerce upgrade under the migration process now.

@badijm badijm marked this pull request as draft October 28, 2020 15:02
@badijm
Copy link
Contributor Author

badijm commented Oct 28, 2020 •
edited

I see your point. I didn't expect it. I'm not sure currently how to handle this. Convert this to draft, will investigate when take time.

@badijm badijm marked this pull request as ready for review April 23, 2021 18:45
@badijm badijm closed this Apr 23, 2021
@badijm badijm deleted the 5096-store-soft-deleted-entity branch April 23, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@exileDev exileDev

Labels
refactoring / source code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@badijm @exileDev @RomanovM