Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize WalletJob's StallMempool #11

Closed
nopara73 opened this issue Mar 23, 2017 · 3 comments
Closed

Optimize WalletJob's StallMempool #11

nopara73 opened this issue Mar 23, 2017 · 3 comments

Comments

@nopara73
Copy link
Owner

After: #6
Related: #10

It's not done in the best possible way, we could gain a second or two refactoring it.
@nopara73 nopara73 mentioned this issue Mar 23, 2017
Closed
@dangershony
Copy link

What's the purpose of mempool? Just storing unconfirmed trx associated to any tracked addresses right?

@nopara73
Copy link
Owner Author

nopara73 commented Mar 31, 2017 •
edited
Loading

Answered here: #10 (comment)

The short answer is no: the MemPoolJob keeps all tx hashes up to date and raises an event when a new transaction arrives (not only tx hash, but full transaction). Also it does not track the transactions, the WalletJob subscribes to the MemPoolJob's transactions and it calls the tracker to process that transaction, if it needs to be tracked or not. Then the tracker starts tracking it or not.

@nopara73
Copy link
Owner Author

nopara73 commented Apr 2, 2017

987dfc6

@nopara73 nopara73 closed this as completed Apr 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dangershony @nopara73