Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port for Insomnia #106

Open
subodhpareek18 opened this issue Aug 16, 2018 · 10 comments
Open

Port for Insomnia #106

subodhpareek18 opened this issue Aug 16, 2018 · 10 comments

Comments

@subodhpareek18
Copy link

subodhpareek18 commented Aug 16, 2018

First of all thank you so much for this great project, I try to use nord theme with whichever tool I work with. (VSCode, Notepad++, Hyper.sh, ConEMU)

One missing link in my setup is a theme for Insomnia, which is a brilliant open source rest client.
https://github.com/getinsomnia/insomnia
https://insomnia.rest/

Themes for insomnia used to be premium only, but ever since the developer reached a certain target of monthly recurring revenue, custom themes were made free for all.

I think a nord themed insomnia would be a great addition.

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Oct 1, 2018

Thanks for your contribution 👍

Sorry for the delay, I've had no free time (job 👨‍⚕️, study 📖, life 🏋️‍♂️ etc.) to work on my or any other :octocat: OSS project (see Tweets 🐦 from April and June), but from the beginning of July I finished my studies and can finally spend time on OSS again 💚

I've added it to the backlog and @-mention you as soon as I start working on it so you can track the progress or contribute ideas for this port project.

Please note that it may take some time because there are many other issues over many other port projects with requests and proposals waiting in the queue. I'm currently also very busy on working and prototyping on the nord-docs to finally have a „single source of truth“ for Nord and all related data. Please also take into account that I work as a software developer in the "real world" and I hope you understand that the time to work on my projects may vary depending on my freetime. :octocat:

@xasx
Copy link

xasx commented Nov 24, 2018

I think at the very first we need to merge the Nord colors into some derivative of this file:

https://github.com/getinsomnia/insomnia/blob/develop/plugins/insomnia-plugin-core-themes/themes/default.js

then glue it together with some descriptors, assemble it somehow and we're done - in theory. I do not feel too comfortable with the first step. In the meanwhile I will try to see whether I can find out something about the assembly of Insomnia plugins.

@xasx
Copy link

xasx commented Nov 25, 2018

Reference Kong/insomnia#1047

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Nov 25, 2018

@xasx Last time I checked Insomnia's documentation and blog, color themes were only available with a paid subscription (only 4 base one for free), but this blog post about providing themes for free as of version 6.0 might be good news to implement a Nord theme. Since the app is completely modularized it might be possible to create a custom plugin (like the one you've linked), but I'm currently not sure if this also works fine for themes.

@xasx
Copy link

xasx commented Nov 25, 2018

My plan was to clone the insomnia-plugin-core-themes plugin and leave only one theme inside and somehow deploy it into Insomnia. If this works, the remaining theme can be Nord-ed.

Any thoughts?

@xasx
Copy link

xasx commented Nov 25, 2018

Find a very rough first version here: https://github.com/xasx/insomnia-plugin-nord-theme

Feel free to file issues, PRs, clone it or whatever.

Probably I need to add a license, do I?

Install instructions for the time being:

  • clone to insomnia plugins folder
  • refresh plugins
  • select Nord theme

@subodhpareek18
Copy link
Author

subodhpareek18 commented Nov 26, 2018

Thank You!! 🎉

Minor Feedback, I'd go with a darker color in the top left where it says Insomnia

@xasx
Copy link

xasx commented Nov 26, 2018

@subodhpareek18 Your feedback is very much appreciated, just add it to xasx/insomnia-plugin-nord-theme#2

From there I can track the changes to the theme and we keep this issue for just having it at all.

@arcticicestudio
Copy link
Contributor

@xasx Great, hanks for your help 👍 , contributions like this are always nice to get things done faster.

Glad to see it gets loaded out-of-the-box™️ without the need to do any “hacks“. I'll let you know as soon as I've got time to create the repository (currently totally busy working on Nord Docs) to form this to an official port project.

@dorg-jmitchem
Copy link

Thanks @xasx for porting this!

@svengreb svengreb changed the title Theme for Insomnia REST Client Port for Insomnia Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants