Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port for asciinema #134

Open
rwev opened this issue Feb 24, 2020 · 5 comments
Open

Port for asciinema #134

rwev opened this issue Feb 24, 2020 · 5 comments

Comments

@rwev
Copy link

rwev commented Feb 24, 2020

A nord terminal theme for asciinema would be a welcome addition to the set of already awesome ports.

Custom asciinema terminal themes HOWTO.

@arcticicestudio
Copy link
Contributor

Hi @rwev 👋, thanks for your contribution 👍

I've added it to the backlog and @-mention you as soon as I start working on it so you can track the progress or contribute ideas for this port project.

Please note that it may take some time for this port project to be implemented.
There is a massive amount of other issues & PRs over many other port projects with requests and proposals waiting in the queue as well as 50+ port project requests in the backlog. I'm currently very busy working and focusing on the data transition of all port projects to the new and shiny website and documentations to finally have a „single source of truth“ for Nord and all related data, reduce the maintenance overhead and increase the overall project quality. :octocat:

Please also take into account that I work as a software developer in the "real world" and I hope you understand that the time to work on my projects may vary depending on my free time. 🙏

Feel free to work on a port on your own and maybe submit it into a public repository so other users can use it in the meantime. This could also help to bootstrap the official port later on by using it as fundamental code base 😄

@rwev
Copy link
Author

rwev commented Feb 26, 2020

Hi,

I've started the port at nord-asciinema. You can see demo here.

I took a somewhat hacky approach - basically just retrofitted the colors in the asciinema player to the terminal in which I made the recording (alacritty + tmux + vim, all with nord themes).

I'd appreciate your feedback, and any corrections you may have.

I'm sure inconsistencies will appear over time because I don't think I properly defined all of the 16 foreground / background color pairs that asciinema demands; only a subset were needed to make my Python demo work.

Thanks again for the already awesome theme and set of ports!

Liebe Gruesse aus Rostock,

Ryan

@rwev
Copy link
Author

rwev commented Feb 26, 2020

I plan on putting a pull request into asciinema-player to add nord to the list of themes available out of the box.

They currently support a small list (tango, solarized-dark, solarized-light, monokai) and I think nord would be a welcome addition.

That said, before it gets added to that central codebase, I'd like to have a more confidence that the the nord-asciinema is complete and consistent with other ports.

Do you think you could do a little testing on your own cases (I'm not sure whether you've had experience with asciinema) and let me know what changes are needed?

@rwev
Copy link
Author

rwev commented Apr 22, 2020

Just touching base on this. Do you have the bandwidth to give it a look?

@arcticicestudio
Copy link
Contributor

It is foreseeable that an official port will unfortunately only be available later due to the high amount of other requests and tasks so I guess making it available as bundled theme is a good way to ship it to users in the meantime.
Since Nord is MIT licensed the Asciinema maintainers/contributors could add it anytime anyway so adding it through the Nord community is by far better 😄
Also great you ask for review and confirmation before submitting it 💪

I know Asciinema (popular choice for CLI based open source app demos) and also used it a couple of times but I'd need to take some more time to review your port. I'll try to read and test it next weekend.

@svengreb svengreb changed the title asciinema player theme Port for asciinema Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants