Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Package details hamburger menu in English while Finnish is selected #49

Closed
ristomatti opened this issue Aug 17, 2020 · 4 comments · Fixed by #51
Closed

Package details hamburger menu in English while Finnish is selected #49

ristomatti opened this issue Aug 17, 2020 · 4 comments · Fixed by #51
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@ristomatti
Copy link
Collaborator

I've set the app language to Finnish but the menu on package details is now in English.

@ristomatti ristomatti added the bug Something isn't working label Aug 17, 2020
@norkator
Copy link
Owner

Related to this: #47

@norkator norkator added the help wanted Extra attention is needed label Aug 17, 2020
@norkator
Copy link
Owner

This is good first issue for somebody wanting to contribute 😸

@ristomatti
Copy link
Collaborator Author

Uh oh. I checked the other issue. It'd be sad to drop the feature as I happen to be using it. I like to keep the system on English but apps primarily designed for Finnish users in Finnish. Usually the language tends to be more fluent and match the context better that way.

The glitches are not a "deal breaker" for me so I'd say leave open until its decided the option is removed. Like mentioned previously I'm not an Android developer but I've seen many apps offer language override feature which definitely works. What I don't know though is if they've had to create a completely custom localisation system which likely wouldn't be a good idea to attempt.

@norkator norkator linked a pull request Aug 18, 2020 that will close this issue
@norkator norkator reopened this Aug 19, 2020
@norkator
Copy link
Owner

I reopened this because not working now in android 7.1.1 and earlier fix breaks app completely there but that crash is fixed with SDK int checking.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants