Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create LICENSE file based on BSD license as per package.xml #485

Merged
merged 3 commits into from
Jan 3, 2022

Conversation

Timple
Copy link
Contributor

@Timple Timple commented Dec 17, 2021

@ethzasl-jenkins
Copy link

Can one of the admins verify this patch?

@pomerlef
Copy link
Collaborator

There is a duplicate commit from #482. Please update the PR.

@Timple
Copy link
Contributor Author

Timple commented Dec 20, 2021

I was under the assumption these commits dropped out upon merging the other PR.

But I updated the PR to a single commit 👍

@stephanemagnenat
Copy link
Collaborator

The license is wrong, the copyright is clearly not 2021 ASL, as Libpointmatcher was created far earlier and people from other institutions have also contributed. The best would be a date range and something like "the Libpointmatcher authors" regarding who owns the copyright.

@pomerlef
Copy link
Collaborator

I'm fine with the changes, but the branch is still out-of-date with master

@Timple
Copy link
Contributor Author

Timple commented Dec 23, 2021

Out of date how?

It only contains the three commits for the license. Or would you like me to rebase onto master?

@pomerlef
Copy link
Collaborator

pomerlef commented Jan 3, 2022

ok to test

@pomerlef pomerlef merged commit c0d13ea into norlab-ulaval:master Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants