Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catkin not required for pure cmake packages #482

Merged
merged 2 commits into from Dec 17, 2021
Merged

catkin not required for pure cmake packages #482

merged 2 commits into from Dec 17, 2021

Conversation

Timple
Copy link
Contributor

@Timple Timple commented Dec 9, 2021

This prevens rosdep resolving in ROS2

@Timple
catkin not required for pure cmake packages
fcee0ed 
This prevens rosdep resolving in ROS2
@ethzasl-jenkins
Copy link

Can one of the admins verify this patch?

@pomerlef
Copy link
Collaborator

pomerlef commented Dec 9, 2021

ok to test

@Timple Timple mentioned this pull request Dec 9, 2021
Closed
@pomerlef
Copy link
Collaborator

pomerlef commented Dec 9, 2021

@simonpierredeschenes can you check if this patch will break default ROS1 installs ?

@simonpierredeschenes
Copy link
Collaborator

I'll have a look

@Timple
Copy link
Contributor Author

Timple commented Dec 10, 2021

For what it's worth: it has beendone before for pure cmake packages 🙂
https://github.com/nobleo/paho.mqtt.c-release/blob/master/patches/package.xml

@pomerlef pomerlef merged commit 7c088aa into norlab-ulaval:master Dec 17, 2021
@pomerlef pomerlef mentioned this pull request Dec 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Timple @ethzasl-jenkins @pomerlef @simonpierredeschenes