Migrate to C++17 #536
Merged
Migrate to C++17 #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
boxanm
requested review from
simonpierredeschenes,
aguenette and
pomerlef
as code owners
|
I will test it on my computer today, but the code looks good, good job! |
simonpierredeschenes
approved these changes
Dec 20, 2023
|
@boxanm I'm bypassing the branch protection rule since all test has passed and @simonpierredeschenes approved the change as a code owner. The missing check was due to a miss-configuration in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my attempt to migrate libpointmatcher to C++17. Unlike #511 , I didn't encounter any errors related to gtest version. It should compile on Ubuntu18.04 and the following releases.
Supporting Bionic is, at the moment, the only thing holding us back from going straight to C++20.