Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THE 2023 release #544

Merged
merged 160 commits into from Dec 29, 2023
Merged

THE 2023 release #544

merged 160 commits into from Dec 29, 2023

Conversation

RedLeader962
Copy link
Collaborator

@RedLeader962 RedLeader962 commented Dec 12, 2023

For approval by @pomerlef

Preparation for release version with commits spanning over close to 5 years.

Note: the code diff between the release branch and the master branch wont reflect the breath of commit added to the proposed release version both in number and type.

Even though there's no API breaking change, since there was a lot of major change and improvement, I propose that this release bump the repository version from to 1.3.12.0.0.
After discussion, will keep major no to 1 for the release

In this PR:

aguenette and others added 30 commits February 20, 2021 13:04
Breaking changes:
- Use the new yaml-cpp API, i.e. version 0.5+.
- No longer provide sources in the contrib directory.
Update to doc, no need to wait for python binding test result
Disable static boost linkage by default
refactor: Drop support for yaml-cpp old API
Fix Transformations test build when using Eigen3.4
…s_in_debug

Fix 2D transformation tests in debug
@RedLeader962
Copy link
Collaborator Author

RedLeader962 commented Dec 18, 2023

I've merged PR #546 in the release. Those are mainly fixes and stabilisation improvement related to the build-system and additions to the repository management:

Build-system related

  • I've added tree scripts to easily launch the build system. They are designed to be used locally as part of a development workflow on a workstation and as part of a CI infrastructure such as TeamCity or GitHub action. See lpm_crawl_[dependencies|libpointmatcher]_build_matrix[.bleeding].bash in build_system/ directory.
  • I've added improvements and fixes to the main README.md header and the Contributing instructions on how to use the libpointmatcher-build-system localy
  • Most libpointmatcher-build-system related script are now properly tested using norlab-shell-script-tools (N2ST) testing tools

Repository management related

  • I've added a pull request template with full instructions on how to proceed for submitting a PR: branching procedure, local testing, required information, contribution guideline ... (see pull_request_template.md in the .github/ dir)
  • I've improved the CODEOWNERS file so that key person get a review request notification when certain area of the codebase are modified by a pull request, eg: if someone push a PR that mess with the build_system/ directory I'll get notified

@boxanm
Copy link
Collaborator

boxanm commented Dec 18, 2023

Before release, I'd like to merge the PR that's supposed to turn up from #454 . Since we dropped support for versions older than Ubuntu 18.04, we could also merge #536 .

@RedLeader962
Copy link
Collaborator Author

... and I've just realized I accidentally merged PR #540 from develop in the release branch, let me know @boxanm I you did not plan to make it part of the this release, I'll find a way to rewrite the commit history

@RedLeader962
Copy link
Collaborator Author

No stress @boxanm, I think you can take the time that you need. People have been waiting for a new release for a few years, they can wait for a few more days. I've notified those that were experiencing install/compiling issue to use the develop branch in the meantime.
Note: I'm switching to integrating NBS to libnabo and norlab-icp-mapper codebase

@RedLeader962
Copy link
Collaborator Author

RedLeader962 commented Dec 18, 2023

@pomerlef I've also added instruction and references to gently guide contributor toward adopting the Conventional Commit specification in their workflow so that we can later use semantic-versioning to automate release process. It's too soon to enforce its uses since libpointmatcher contributors already have an establish workflow and need some kinds of heads up. See pull_request_template.md and commit_msg_reference.md

boxanm and others added 18 commits December 18, 2023 11:56
@boxanm I'm bypassing the branch protection rule since all test has passed and @simonpierredeschenes approved the the change as a code owner.  The missing check was due to a miss-configuration in the `CODEOWNERS` file that required an approval by @pomerlef  on all changes to the codebase. I'll push a fix so that he receive request for selected files that require admin oversight and keep the rest of the codebase under the responsibility of the maintainer group
…view request only for high-level file. Updated submodule to latest.
…ementation-and-refactor-out-to-NBS-generic-install-logic-NMO-436
…have cloned the repo [NMO-353]

- feat: implemented a user side installer script for libpointmatcher dependencies and libpointmatcher (it call the build system version under the hood)
- fix: solved the logic for passing CMAKE_INSTALL_PREFIX flag to the sourced installer sub-script
- feat: added a `--test-run` flag plus dry-run logic to `lpm_install.*.bash` script for efficiently testing `lpm_install.*.bash` and `libpointmatcher_[dependencies_]installer.bash` scripts
- fix: solved the build system installer git checkout tag landing out of the if clause on the parent level

- test: added build system installer related bats test
- test: added user installer related bats test
- test: added `.env.libpointmatcher` bats test

#### Others
- ci(codeowner): update and clean entries
- chore: added convenient run configuration for script help menu
- update NBS and N2ST submodule to latest
…utput redirection to stder on error [NMO-457]
…tmatcher-turnkey-install-scripts-for-user-who-have-cloned-the-repo-NMO-353

feat: implement libpointmatcher turnkey install scripts for user who have cloned the repo
Copy link

sonarcloud bot commented Dec 23, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

43 New issues
0 Security Hotspots
No data about Coverage
0.4% Duplication on New Code

See analysis details on SonarCloud

@boxanm boxanm marked this pull request as ready for review December 23, 2023 20:28
@boxanm boxanm requested a review from pomerlef December 28, 2023 15:25
.github/CODEOWNERS Show resolved Hide resolved
@RedLeader962
Copy link
Collaborator Author

@pomerlef I was wondering if we should put the new Contributing section currently in the main readme to a dedicated file eg docs/contributing.md.
Also I forgot to mention the new installer script in the readme. I'll add it after the holiday

@boxanm boxanm merged commit 1a3a4b3 into master Dec 29, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants