Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

General - Abstract Card Component #737

Closed
jamescd18 opened this issue Jun 18, 2022 · 0 comments · Fixed by #752
Closed

General - Abstract Card Component #737

jamescd18 opened this issue Jun 18, 2022 · 0 comments · Fixed by #752
Assignees
@jamescd18
Labels
difficult This task is difficult front-end Visual layout, styling, or view-specific issues improvement Primarily tech debt, performance improvements, refactoring new feature Features which don't currently exist

Comments

@jamescd18
Copy link
Member

Current Features

Currently various different parts of the app use the bootstrap-react Card component in a few different ways. Anywhere it's used requires having the theme hook so that the card can be theme-styled. This may potentially create unnecessary code duplication.

Desired Additional Features

Examine the different usages of the Card component and see if a flexible abstracted card component could be created for use across the application, much in the same way we have the reusable page block component. This could help reduce the number of cases where we have the theme provider.

Screenshots (as needed)

No response
@jamescd18 jamescd18 added front-end Visual layout, styling, or view-specific issues new feature Features which don't currently exist improvement Primarily tech debt, performance improvements, refactoring difficult This task is difficult labels Jun 18, 2022
@jamescd18 jamescd18 self-assigned this Jun 26, 2022
jamescd18 added a commit that referenced this issue Jun 26, 2022
@jamescd18
#737 - remove extraneous react fragment
95b0bca
jamescd18 added a commit that referenced this issue Jun 26, 2022
@jamescd18
#737 - make table filters use page block instead of bootstrap card
36f5bb3
jamescd18 added a commit that referenced this issue Jun 26, 2022
@jamescd18
#737 - make page block header right optional
8a29dc3
jamescd18 added a commit that referenced this issue Jun 26, 2022
@jamescd18
#737 - update page block tests
d93d237
jamescd18 added a commit that referenced this issue Jun 26, 2022
@jamescd18
#737 - convert from page block body to page block children and lil cl…
b85fab4 
…eanup
jamescd18 added a commit that referenced this issue Jun 26, 2022
@jamescd18
#737 - update page block documentation
7db9282
jamescd18 added a commit that referenced this issue Jun 26, 2022
@jamescd18
#737 - switch header right to ReactNode for future flexibility
3613538
@jamescd18 jamescd18 mentioned this issue Jun 26, 2022
Merged
12 tasks
jamescd18 added a commit that referenced this issue Jun 26, 2022
@jamescd18
#737 - merge with main
7170c20
jamescd18 added a commit that referenced this issue Jun 26, 2022
@jamescd18
#737 - switch jsx.element to ReactNode
e38db8b
jamescd18 added a commit that referenced this issue Jun 26, 2022
@jamescd18
Merge pull request #752 from Northeastern-Electric-Racing/#737-abstra…
0c97839 
…ct-card

#737 abstract card
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jamescd18 jamescd18

Labels
difficult This task is difficult front-end Visual layout, styling, or view-specific issues improvement Primarily tech debt, performance improvements, refactoring new feature Features which don't currently exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#737 abstract card Northeastern-Electric-Racing/PM-Dashboard-v2
1 participant
@jamescd18