-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for class shortcut in hiccup: :div.foo
?
#29
Comments
It's not a hill I would die on, but I purposely didn't add it because I never use it. I'm not completely opposed to adding it, but there are downsides: complecting tag and props complicates threading props down the component tree when you want to override class / id. It might be useful to help people move from reagent to hx. Is it something you find important? |
To be honest, it just took me surprise. I agree that it’s complecting some things and makes the library more magic than it needs to. I’ll get back to you after a few more days of using the library and see if it’s something I really miss or just force of habit.
… It's not a hill I would die on, but I purposely didn't add it because I never use it.
I'm not completely opposed to adding it, but there are downsides: complecting tag and props complicates threading props down the component tree when you want to override class / id.
It might be useful to help people move from reagent to hx. Is it something you find important?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I would leave it as it is. This specific class and id make my code more understandable. I just moved https://github.com/laststar/showrum (everything but the README :) ) from run to hx in and this bit me more than once, but still, I like it more this way. |
Closing this for now. |
Hi, I've noticed that a very common reagent pattern, i.e.
:div.foo
to add thefoo
class to:div
isn't supported in hx. Is this by design?The text was updated successfully, but these errors were encountered: