Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for class shortcut in hiccup: :div.foo? #29

Closed
orestis opened this issue Mar 4, 2019 · 4 comments
Closed

Support for class shortcut in hiccup: :div.foo? #29

orestis opened this issue Mar 4, 2019 · 4 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@orestis
Copy link
Member

orestis commented Mar 4, 2019

Hi, I've noticed that a very common reagent pattern, i.e. :div.foo to add the foo class to :div isn't supported in hx. Is this by design?

@lilactown
Copy link
Collaborator

It's not a hill I would die on, but I purposely didn't add it because I never use it.

I'm not completely opposed to adding it, but there are downsides: complecting tag and props complicates threading props down the component tree when you want to override class / id.

It might be useful to help people move from reagent to hx. Is it something you find important?

@orestis
Copy link
Member Author

orestis commented Mar 4, 2019 via email

@pepe
Copy link

pepe commented Mar 5, 2019

I would leave it as it is. This specific class and id make my code more understandable.

I just moved https://github.com/laststar/showrum (everything but the README :) ) from run to hx in and this bit me more than once, but still, I like it more this way.

@lilactown lilactown added the enhancement New feature or request label Mar 10, 2019
@lilactown lilactown added the wontfix This will not be worked on label Mar 18, 2019
@lilactown
Copy link
Collaborator

Closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants