Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROT13 cipher: Issues in current implementation #4

Open
kobby-pentangeli opened this issue Sep 11, 2023 · 0 comments
Open

ROT13 cipher: Issues in current implementation #4

kobby-pentangeli opened this issue Sep 11, 2023 · 0 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers

Comments

@kobby-pentangeli
Copy link
Contributor

The current implementation is quite solid and doesn't seem to have any particular vulnerabilities intrinsic to the algorithm or code. However, one could consider potential attacks not on the cipher logic itself, but on how the program interacts with its environment or handles input. Here are some considerations:

  1. Input Handling:
  • In the future, if we add more features, we must ensure that inputs are validated properly to avoid issues like buffer overflow or injection attacks.
  1. Error Handling:
  • As of now, the program doesn't have proper custom error handling. In a more comprehensive application, lack of error handling could potentially be exploited or result in unexpected behaviour.
@kobby-pentangeli kobby-pentangeli added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers labels Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant