Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows fixes #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Windows fixes #58

wants to merge 2 commits into from

Conversation

konstantint
Copy link

Changes useful for those installing the package on Windows

jaredly
jaredly requested changes Dec 14, 2017
View reviewed changes
Copy link
Member

@jaredly jaredly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help! It looks like you got rid of the mkdir -p -- don't we still need that? (or something like it)

@konstantint
Copy link
Author

install.js does mkdirp anyway, doesn't it?

@Eoksni
Copy link

Eoksni commented Jan 8, 2018

I just want to confirm that by following instructions in this pull request I managed to install this kernel on Win 10 with no problems.

@Eoksni
Copy link

Eoksni commented Jan 8, 2018

Although I would make a recommendation to make it work with anaconda as well. Because when I ran install process from within anaconda console, it couldn't find Python, even though it is obviously there. So I had to install windows-build-tools to make python globally available (outside of anaconda), then this kernel installed itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredly jaredly jaredly requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@konstantint @Eoksni @jaredly