Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows fixes #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Windows fixes #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6554d5b
Fix: process.env.HOME is undefined on Windows
konstantint Dec 13, 2017
14018e1
Extended Windows-specific instructions
konstantint Dec 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions Readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,14 @@ Get it while it's hot! or view the [example notebook](http://nbviewer.ipython.or
```bash
git clone https://github.com/notablemind/jupyter-nodejs.git
cd jupyter-nodejs
mkdir -p ~/.ipython/kernels/nodejs/
npm install && node install.js
npm install
node install.js
npm run build
npm run build-ext
jupyter console --kernel nodejs
```

And viola!
And voilà!

![image](https://cloud.githubusercontent.com/assets/112170/7268122/a33b186c-e882-11e4-8463-be00a6c90163.png)

Expand All @@ -29,9 +29,19 @@ Also, in the iPython notebook:

![image](https://cloud.githubusercontent.com/assets/112170/7268108/70cade4e-e882-11e4-95e7-8a7375b3b888.png)

### Windows-specific installation notes

If the installation procedure above fails on `npm install`, complaining it cannot find the Python executable, try first installing `windows-build-tools` globally, by running as administrator:
```bash
npm install --global --production windows-build-tools
```
Then also install [node-gyp](https://github.com/nodejs/node-gyp) and `zmq` globally (not necessarily as Administrator):
```bash
npm install --global node-gyp
npm install --global zmq
```

## Supported features:
## Supported features

- tab-completion (both for variables and **paths**)
- error reporting
Expand Down
7 changes: 6 additions & 1 deletion install.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,12 @@ var fs = require('fs')
var path = require('path')
var mkdirp = require('mkdirp')

var installPath = path.join(process.env.HOME, '.ipython/kernels/nodejs')
var installPath;
if (process.platform == 'win32') // NB: this is true for both 32- and 64-bit Windows
installPath = path.join(process.env.APPDATA, 'jupyter/kernels/nodejs')
else
installPath = path.join(process.env.HOME, '.ipython/kernels/nodejs')

if (process.argv.length >= 3) {
installPath = process.argv[2]
}
Expand Down