Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move constants to separate namespace #14

Closed
Flambino opened this issue Nov 30, 2011 · 1 comment
Closed

Move constants to separate namespace #14

Flambino opened this issue Nov 30, 2011 · 1 comment
Labels
Can be closed? code improvement
Milestone
Beta 02

Comments

@Flambino
Copy link
Contributor

Various error constants are currently in the global (i.e. window) namespace. To keep the code's global footprint to a minimum, these constants should probably be moved to their own namespace. E.g. move window.RPC_TIMEOUT_ERROR to LYT.constants.RPC_TIMEOUT_ERROR or simply LYT.RPC_TIMEOUT_ERROR
@Flambino Flambino mentioned this issue Dec 21, 2011
Closed
@mzedeler
Copy link
Contributor

I have converted this to TODOs in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Can be closed? code improvement
Projects
None yet
Milestone
Beta 02
Development

No branches or pull requests
2 participants
@Flambino @mzedeler