Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenerateEnvelope plugin request doesnot have expiry. #443

Closed
priteshbandi opened this issue Nov 11, 2022 · 2 comments
Closed

GenerateEnvelope plugin request doesnot have expiry. #443

priteshbandi opened this issue Nov 11, 2022 · 2 comments
Assignees
Labels
bug Something isn't working triage Need to triage
Milestone

Comments

@priteshbandi
Copy link
Contributor

priteshbandi commented Nov 11, 2022

What is the areas you experience the issue in?

Notation-Core-Go Library

What is not working as expected?

The generate-envelope plugin request doesnt has access to expiry.

https://github.com/notaryproject/notaryproject/blob/main/specs/plugin-extensibility.md#generate-envelope

// Request
{
  "contractVersion" : "<major-version.minor-version>",
  
  // Key id associated with signing key (keyName)
  // in config.json /signingKeys/keys
  "keyId": "<key id>",

  // Optional plugin configuration, map of string-string
  "pluginConfig" : { },

  "payload" : "<Base64 encoded payload to be signed>",
  
  // The type of payload - currently a descriptor
  "payloadType" : "application/vnd.cncf.notary.payload.v1+json",
  
  // The expected response signature envelope
  "signatureEnvelopeType" : "application/jose+json"
}

What did you expect to happen?

the generate-envelope plugin request should have access to expiry

How can we reproduce it?

NA

Describe your environment

NA

What is the version of your Notation CLI or Notation Library?

NA

@priteshbandi priteshbandi added bug Something isn't working triage Need to triage labels Nov 11, 2022
@priteshbandi priteshbandi changed the title GenerateEnvelope plugin request not having access to expiry. GenerateEnvelope plugin request doesnot have access to expiry. Nov 11, 2022
@priteshbandi priteshbandi changed the title GenerateEnvelope plugin request doesnot have access to expiry. GenerateEnvelope plugin request doesnot have expiry. Nov 11, 2022
@priteshbandi priteshbandi added this to the RC-1 milestone Nov 11, 2022
@yizha1
Copy link
Contributor

yizha1 commented Nov 15, 2022

Per community discussion, this issue is in RC-1 scope.

  • Update plugin spec
  • Notation Implementation
  • Notation 3rd party plugin Implementation (no impact on sign plugin)

priteshbandi added a commit to notaryproject/specifications that referenced this issue Nov 29, 2022
Pass expiry to envelope generator plugin so that it can be used for generating signature.
Issue: notaryproject/notation#443

Signed-off-by: Pritesh Bandi pritesb@amazon.com
priteshbandi added a commit to notaryproject/notation-go that referenced this issue Dec 2, 2022
There will be two PRs, one in notation-go([PR#222](#222))
and other in notation([PR#458](notaryproject/notation#458)) repo.

*Tests are failing because this PR depends on #222

Issue: notaryproject/notation#443

Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
priteshbandi added a commit that referenced this issue Dec 2, 2022
There will be two PRs, one in notation-go([PR#222](notaryproject/notation-go#222))
and other in notation([PR#458](#458)) repo.

Issue: #443

Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
@yizha1
Copy link
Contributor

yizha1 commented Dec 2, 2022

Closed as all PRs merged

@yizha1 yizha1 closed this as completed Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Need to triage
Projects
Status: Done
Development

No branches or pull requests

2 participants