-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GenerateEnvelope plugin request doesnot have expiry. #443
Comments
Per community discussion, this issue is in RC-1 scope.
|
priteshbandi
added a commit
to notaryproject/specifications
that referenced
this issue
Nov 29, 2022
Pass expiry to envelope generator plugin so that it can be used for generating signature. Issue: notaryproject/notation#443 Signed-off-by: Pritesh Bandi pritesb@amazon.com
This was referenced Nov 30, 2022
priteshbandi
added a commit
to notaryproject/notation-go
that referenced
this issue
Dec 2, 2022
There will be two PRs, one in notation-go([PR#222](#222)) and other in notation([PR#458](notaryproject/notation#458)) repo. *Tests are failing because this PR depends on #222 Issue: notaryproject/notation#443 Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
priteshbandi
added a commit
that referenced
this issue
Dec 2, 2022
There will be two PRs, one in notation-go([PR#222](notaryproject/notation-go#222)) and other in notation([PR#458](#458)) repo. Issue: #443 Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
Closed as all PRs merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the areas you experience the issue in?
Notation-Core-Go Library
What is not working as expected?
The generate-envelope plugin request doesnt has access to expiry.
https://github.com/notaryproject/notaryproject/blob/main/specs/plugin-extensibility.md#generate-envelope
What did you expect to happen?
the generate-envelope plugin request should have access to expiry
How can we reproduce it?
NA
Describe your environment
NA
What is the version of your Notation CLI or Notation Library?
NA
The text was updated successfully, but these errors were encountered: