Pass expiry to envelope-generator plugin #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priteshbandi
commented
Nov 30, 2022
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
Co-authored-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
shizhMSFT
reviewed
Nov 30, 2022
jondonas
approved these changes
Dec 1, 2022
shizhMSFT
reviewed
Dec 1, 2022
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
patrickzheng200
approved these changes
Dec 2, 2022
Codecov Report
@@ Coverage Diff @@
## main #222 +/- ##
==========================================
+ Coverage 72.06% 73.19% +1.13%
==========================================
Files 23 23
Lines 1600 1608 +8
==========================================
+ Hits 1153 1177 +24
+ Misses 364 339 -25
- Partials 83 92 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
priteshbandi
added a commit
to notaryproject/notation
that referenced
this pull request
Dec 2, 2022
There will be two PRs, one in notation-go([PR#222](notaryproject/notation-go#222)) and other in notation([PR#458](#458)) repo. Issue: #443 Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There will be two PRs, one in notation-go(PR#222) and other in notation(PR#458) repo.
Tests are failing because this PR depends on #222
Issue: notaryproject/notation#443
Signed-off-by: Pritesh Bandi pritesb@amazon.com