Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass expiry to envelope-generator plugin #458

Merged
merged 2 commits into from
Dec 2, 2022

Conversation

priteshbandi
Copy link
Contributor

@priteshbandi priteshbandi commented Nov 30, 2022

There will be two PRs, one in notation-go(PR#222) and other in notation(PR#458) repo.

Issue: #443

Signed-off-by: Pritesh Bandi pritesb@amazon.com

@priteshbandi priteshbandi changed the title Updates to pass expiry to envelope-generator plugin Pass expiry to envelope-generator plugin Nov 30, 2022
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
cmd/notation/sign.go Outdated Show resolved Hide resolved
priteshbandi added a commit to notaryproject/notation-go that referenced this pull request Dec 2, 2022
There will be two PRs, one in notation-go([PR#222](#222))
and other in notation([PR#458](notaryproject/notation#458)) repo.

*Tests are failing because this PR depends on #222

Issue: notaryproject/notation#443

Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
fix
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
@codecov-commenter
Copy link

Codecov Report

Merging #458 (b5d8d63) into main (86287b5) will decrease coverage by 0.30%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
- Coverage   32.48%   32.17%   -0.31%     
==========================================
  Files          25       25              
  Lines        1250     1262      +12     
==========================================
  Hits          406      406              
- Misses        832      844      +12     
  Partials       12       12              
Impacted Files Coverage Δ
cmd/notation/sign.go 44.30% <0.00%> (-1.16%) ⬇️
cmd/notation/cert/list.go 13.55% <0.00%> (-0.24%) ⬇️
cmd/notation/cert/generateTest.go 16.52% <0.00%> (-0.15%) ⬇️
cmd/notation/plugin.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit 3c43168 into notaryproject:main Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants