-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for signed user metadata in notation sign and verify cmds #507
feat: add support for signed user metadata in notation sign and verify cmds #507
Conversation
Signed-off-by: Byron Chien <chienb@amazon.com>
related: notaryproject/notation-go#242 |
Signed-off-by: Byron Chien <chienb@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The pipeline was failed. Please update the code. |
This PR depends on notaryproject/notation-go#242 and that's the reason build is failing. @JeyJeyGao In the spirit of expediting the rc2 release, can you please review the code, we can make a small update when notaryproject/notation-go#242 is merged ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Byron Chien <chienb@amazon.com>
Signed-off-by: Byron Chien <chienb@amazon.com>
Signed-off-by: Byron Chien <chienb@amazon.com>
Signed-off-by: Byron Chien <chienb@amazon.com>
Signed-off-by: Byron Chien <chienb@amazon.com>
27396c8
to
5f040e0
Compare
Co-authored-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: Byron Chien <chienb@amazon.com>
Signed-off-by: Byron Chien <chienb@amazon.com>
5f040e0
to
1c3cddf
Compare
Signed-off-by: Byron Chien <chienb@amazon.com>
@byronchien could you fix the conflict? |
resolved conflict |
Signed-off-by: Byron Chien <chienb@amazon.com>
Signed-off-by: Byron Chien <chienb@amazon.com>
a5d4634
to
8b8ea52
Compare
Signed-off-by: Byron Chien <chienb@amazon.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #507 +/- ##
==========================================
+ Coverage 35.15% 36.06% +0.90%
==========================================
Files 29 29
Lines 1502 1528 +26
==========================================
+ Hits 528 551 +23
- Misses 955 958 +3
Partials 19 19
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Adds support for signed user metadata in
notation sign
andnotation verify
. Relevant specThis PR depends on notaryproject/notation-go#242 please review notation-go/pull/242 first
example sign usage:
example metadata displayed on verification (without metadata flag)
example verification:
example verification failure
Not in this PR: error messaging. In the spec update, we mentioned that there should be an error message if the verification fails due to the metadata not being present, but if there are multiple verifications that fail for different reasons, is there a desired order to prioritize the what the end error message displayed is?
Signed-off-by: Byron Chien chienb@amazon.com