Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for signed user metadata in notation sign and verify cmds #507

Merged
merged 13 commits into from
Feb 8, 2023
Merged

feat: add support for signed user metadata in notation sign and verify cmds #507

merged 13 commits into from
Feb 8, 2023

Commits on Jan 13, 2023

  1. Adds additional flag and passes values to notation-go 

    Signed-off-by: Byron Chien <chienb@amazon.com>
    Byron Chien committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    0488b33 View commit details
    Browse the repository at this point in the history

  2. Fix usage, add error message 

    Signed-off-by: Byron Chien <chienb@amazon.com>
    Byron Chien committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    e0c5113 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. Merge branch 'notaryproject:main' into attestations-impl 

    Signed-off-by: Byron Chien <chienb@amazon.com>
    @byronchien
    byronchien authored and Byron Chien committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    0160c8d View commit details
    Browse the repository at this point in the history

  2. Ignore envelope parsing error and explain in comment 

    Signed-off-by: Byron Chien <chienb@amazon.com>
    Byron Chien committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    7e3e9e4 View commit details
    Browse the repository at this point in the history

  3. use RemoteSignOptions and fix verify error 

    Signed-off-by: Byron Chien <chienb@amazon.com>
    Byron Chien committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    5fa6511 View commit details
    Browse the repository at this point in the history

  4. Use embedded struct 

    Signed-off-by: Byron Chien <chienb@amazon.com>
    Byron Chien committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    9a54cbc View commit details
    Browse the repository at this point in the history

  5. Update UserMetadata() usage 

    Signed-off-by: Byron Chien <chienb@amazon.com>
    Byron Chien committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    431ecbf View commit details
    Browse the repository at this point in the history

  6. Update cmd/notation/sign.go 

    Co-authored-by: Patrick Zheng <patrickzheng@microsoft.com>

Signed-off-by: Byron Chien <chienb@amazon.com>
    @byronchien
    byronchien authored and Byron Chien committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    5ae32bb View commit details
    Browse the repository at this point in the history

  7. Fix RemoteSignOptions initialization 

    Signed-off-by: Byron Chien <chienb@amazon.com>
    Byron Chien committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    1c3cddf View commit details
    Browse the repository at this point in the history

  8. Spacing nit, check metadata presence 

    Signed-off-by: Byron Chien <chienb@amazon.com>
    Byron Chien committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    2760660 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. Merge branch 'main' into attestations-impl 

    Signed-off-by: Byron Chien <chienb@amazon.com>
    @byronchien
    byronchien authored and Byron Chien committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    8b39d13 View commit details
    Browse the repository at this point in the history

  2. Use ParseFlagMap instead of ParseFlagPluginConfig 

    Signed-off-by: Byron Chien <chienb@amazon.com>
    Byron Chien committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    8b8ea52 View commit details
    Browse the repository at this point in the history

  3. Update go.mod for notation-go changes 

    Signed-off-by: Byron Chien <chienb@amazon.com>
    Byron Chien committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    de7057b View commit details
    Browse the repository at this point in the history