Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vani Rao as notaryproject maintainer #229

Closed
wants to merge 1 commit into from
Closed

Add Vani Rao as notaryproject maintainer #229

wants to merge 1 commit into from

Conversation

vaninrao10
Copy link

Add Vani Rao as a seed maintainer of notaryproject based on their activity and as per - #224

Signed-off-by: vaninrao10 111005862+vaninrao10@users.noreply.github.com

@vaninrao10
Add Vani Rao as notaryproject maintainer
113313a 
Add Vani Rao as notaryproject maintainer

Signed-off-by: vaninrao10 <111005862+vaninrao10@users.noreply.github.com>
priteshbandi
priteshbandi approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but IANAM

toddysm
toddysm approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@toddysm toddysm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but IANAM

SteveLasker
SteveLasker approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FeynmanZhou
FeynmanZhou approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but IANAM

yizha1
yizha1 approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but IANAM

@toddysm toddysm mentioned this pull request Feb 8, 2023
Merged
gokarnm
gokarnm approved these changes Feb 11, 2023
View reviewed changes
Copy link
Contributor

@gokarnm gokarnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but IANAM

priteshbandi pushed a commit that referenced this pull request Feb 16, 2023
@toddysm
Added CODEOWNERS and MAINTAINERS files (#240)
62ae4cf 
This PR combines all the changes from the following PRs for updating the maintainers for notaryproject/notaryproject sub-project:
Add Milind Gokarn #228
Add Pritesh Bandi #227
Add Shiwei Zhang #234
Add Toddy Mladenov #236
Add Vani Rao #229
Add Yi Zha #237

To keep a balance I dropped Add Feynman Zhou #235. The proposal is to abandon the above PRs and merge only this one.

Signed-off-by: Toddy Mladenov toddysm@gmail.com
@yizha1
Copy link
Contributor

yizha1 commented Feb 17, 2023

Close as aggregated PR #240 was merged.

@yizha1 yizha1 closed this Feb 17, 2023
FeynmanZhou pushed a commit to FeynmanZhou/notaryproject that referenced this pull request Feb 24, 2023
@toddysm @FeynmanZhou
Added CODEOWNERS and MAINTAINERS files (notaryproject#240)
8cc588c 
This PR combines all the changes from the following PRs for updating the maintainers for notaryproject/notaryproject sub-project:
Add Milind Gokarn notaryproject#228
Add Pritesh Bandi notaryproject#227
Add Shiwei Zhang notaryproject#234
Add Toddy Mladenov notaryproject#236
Add Vani Rao notaryproject#229
Add Yi Zha notaryproject#237

To keep a balance I dropped Add Feynman Zhou notaryproject#235. The proposal is to abandon the above PRs and merge only this one.

Signed-off-by: Toddy Mladenov toddysm@gmail.com
FeynmanZhou pushed a commit to FeynmanZhou/notaryproject that referenced this pull request Feb 24, 2023
@toddysm @FeynmanZhou
Added CODEOWNERS and MAINTAINERS files (notaryproject#240)
0b52656 
This PR combines all the changes from the following PRs for updating the maintainers for notaryproject/notaryproject sub-project:
Add Milind Gokarn notaryproject#228
Add Pritesh Bandi notaryproject#227
Add Shiwei Zhang notaryproject#234
Add Toddy Mladenov notaryproject#236
Add Vani Rao notaryproject#229
Add Yi Zha notaryproject#237

To keep a balance I dropped Add Feynman Zhou notaryproject#235. The proposal is to abandon the above PRs and merge only this one.

Signed-off-by: Toddy Mladenov toddysm@gmail.com
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
FeynmanZhou pushed a commit to FeynmanZhou/notaryproject that referenced this pull request Feb 24, 2023
@toddysm @FeynmanZhou
Added CODEOWNERS and MAINTAINERS files (notaryproject#240)
d0f4b7d 
This PR combines all the changes from the following PRs for updating the maintainers for notaryproject/notaryproject sub-project:
Add Milind Gokarn notaryproject#228
Add Pritesh Bandi notaryproject#227
Add Shiwei Zhang notaryproject#234
Add Toddy Mladenov notaryproject#236
Add Vani Rao notaryproject#229
Add Yi Zha notaryproject#237

To keep a balance I dropped Add Feynman Zhou notaryproject#235. The proposal is to abandon the above PRs and merge only this one.

Signed-off-by: Toddy Mladenov toddysm@gmail.com
FeynmanZhou pushed a commit to FeynmanZhou/notaryproject that referenced this pull request Feb 24, 2023
@toddysm @FeynmanZhou
Added CODEOWNERS and MAINTAINERS files (notaryproject#240)
400564e 
This PR combines all the changes from the following PRs for updating the maintainers for notaryproject/notaryproject sub-project:
Add Milind Gokarn notaryproject#228
Add Pritesh Bandi notaryproject#227
Add Shiwei Zhang notaryproject#234
Add Toddy Mladenov notaryproject#236
Add Vani Rao notaryproject#229
Add Yi Zha notaryproject#237

To keep a balance I dropped Add Feynman Zhou notaryproject#235. The proposal is to abandon the above PRs and merge only this one.

Signed-off-by: Toddy Mladenov toddysm@gmail.com
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
FeynmanZhou pushed a commit to FeynmanZhou/notaryproject that referenced this pull request Feb 24, 2023
@toddysm @FeynmanZhou
Added CODEOWNERS and MAINTAINERS files (notaryproject#240)
0ea2bc5 
This PR combines all the changes from the following PRs for updating the maintainers for notaryproject/notaryproject sub-project:
Add Milind Gokarn notaryproject#228
Add Pritesh Bandi notaryproject#227
Add Shiwei Zhang notaryproject#234
Add Toddy Mladenov notaryproject#236
Add Vani Rao notaryproject#229
Add Yi Zha notaryproject#237

To keep a balance I dropped Add Feynman Zhou notaryproject#235. The proposal is to abandon the above PRs and merge only this one.

Signed-off-by: Toddy Mladenov toddysm@gmail.com
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
toddysm added a commit that referenced this pull request Mar 21, 2023
@toddysm
chore: fix syntax error in CODEOWNERS file (#243)
20b669d 
* doc: Add Yi as a notaryproject maintainer

Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>

* Added CODEOWNERS and MAINTAINERS files (#240)

This PR combines all the changes from the following PRs for updating the maintainers for notaryproject/notaryproject sub-project:
Add Milind Gokarn #228
Add Pritesh Bandi #227
Add Shiwei Zhang #234
Add Toddy Mladenov #236
Add Vani Rao #229
Add Yi Zha #237

To keep a balance I dropped Add Feynman Zhou #235. The proposal is to abandon the above PRs and merge only this one.

Signed-off-by: Toddy Mladenov toddysm@gmail.com
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>

* fix syntax error in CODEOWNERS file

Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>

    pick d194f78 fix syntax error in CODEOWNERS file

Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>

* fix syntax error in CODEOWNERS file

Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>

    pick d194f78 fix syntax error in CODEOWNERS file

Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>

* Added CODEOWNERS and MAINTAINERS files (#240)

This PR combines all the changes from the following PRs for updating the maintainers for notaryproject/notaryproject sub-project:
Add Milind Gokarn #228
Add Pritesh Bandi #227
Add Shiwei Zhang #234
Add Toddy Mladenov #236
Add Vani Rao #229
Add Yi Zha #237

To keep a balance I dropped Add Feynman Zhou #235. The proposal is to abandon the above PRs and merge only this one.

Signed-off-by: Toddy Mladenov toddysm@gmail.com
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>

* chore: fix conflicts

Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>

    pick eaefc35 chore: fix conflicts

Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>

* fix conflicts

Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>

* fix git signing problem

Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>

* add a new line at the end

Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>

* fix syntax in MAINTAINERS

Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>

---------

Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Toddy Mladenov toddysm@gmail.com
Co-authored-by: Toddy Mladenov <me@toddysm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toddysm toddysm toddysm approved these changes

@gokarnm gokarnm gokarnm approved these changes

@priteshbandi priteshbandi priteshbandi approved these changes

@SteveLasker SteveLasker SteveLasker approved these changes

@FeynmanZhou FeynmanZhou FeynmanZhou approved these changes

@iamsamirzon iamsamirzon iamsamirzon approved these changes

@yizha1 yizha1 yizha1 approved these changes

@binbin-li binbin-li Awaiting requested review from binbin-li

@JeyJeyGao JeyJeyGao Awaiting requested review from JeyJeyGao

@jondonas jondonas Awaiting requested review from jondonas

@lachie83 lachie83 Awaiting requested review from lachie83

@patrickzheng200 patrickzheng200 Awaiting requested review from patrickzheng200

@rgnote rgnote Awaiting requested review from rgnote

@sajayantony sajayantony Awaiting requested review from sajayantony

@shizhMSFT shizhMSFT Awaiting requested review from shizhMSFT shizhMSFT is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@vaninrao10 @yizha1 @toddysm @gokarnm @priteshbandi @SteveLasker @FeynmanZhou @iamsamirzon