-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CODEOWNERS and MAINTAINERS files #240
Added CODEOWNERS and MAINTAINERS files #240
Conversation
Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Linking the issue #224 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but IANAM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but IANAM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but IANAM
LGTM but IANAM |
1 similar comment
LGTM but IANAM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Welcome new maintainers!
Pinging @justincormack for a unanimous vote of the org maintainers. |
This PR combines all the changes from the following PRs for updating the maintainers for notaryproject/notaryproject sub-project: Add Milind Gokarn notaryproject#228 Add Pritesh Bandi notaryproject#227 Add Shiwei Zhang notaryproject#234 Add Toddy Mladenov notaryproject#236 Add Vani Rao notaryproject#229 Add Yi Zha notaryproject#237 To keep a balance I dropped Add Feynman Zhou notaryproject#235. The proposal is to abandon the above PRs and merge only this one. Signed-off-by: Toddy Mladenov toddysm@gmail.com
This PR combines all the changes from the following PRs for updating the maintainers for notaryproject/notaryproject sub-project: Add Milind Gokarn notaryproject#228 Add Pritesh Bandi notaryproject#227 Add Shiwei Zhang notaryproject#234 Add Toddy Mladenov notaryproject#236 Add Vani Rao notaryproject#229 Add Yi Zha notaryproject#237 To keep a balance I dropped Add Feynman Zhou notaryproject#235. The proposal is to abandon the above PRs and merge only this one. Signed-off-by: Toddy Mladenov toddysm@gmail.com Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
This PR combines all the changes from the following PRs for updating the maintainers for notaryproject/notaryproject sub-project: Add Milind Gokarn notaryproject#228 Add Pritesh Bandi notaryproject#227 Add Shiwei Zhang notaryproject#234 Add Toddy Mladenov notaryproject#236 Add Vani Rao notaryproject#229 Add Yi Zha notaryproject#237 To keep a balance I dropped Add Feynman Zhou notaryproject#235. The proposal is to abandon the above PRs and merge only this one. Signed-off-by: Toddy Mladenov toddysm@gmail.com
This PR combines all the changes from the following PRs for updating the maintainers for notaryproject/notaryproject sub-project: Add Milind Gokarn notaryproject#228 Add Pritesh Bandi notaryproject#227 Add Shiwei Zhang notaryproject#234 Add Toddy Mladenov notaryproject#236 Add Vani Rao notaryproject#229 Add Yi Zha notaryproject#237 To keep a balance I dropped Add Feynman Zhou notaryproject#235. The proposal is to abandon the above PRs and merge only this one. Signed-off-by: Toddy Mladenov toddysm@gmail.com Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
This PR combines all the changes from the following PRs for updating the maintainers for notaryproject/notaryproject sub-project: Add Milind Gokarn notaryproject#228 Add Pritesh Bandi notaryproject#227 Add Shiwei Zhang notaryproject#234 Add Toddy Mladenov notaryproject#236 Add Vani Rao notaryproject#229 Add Yi Zha notaryproject#237 To keep a balance I dropped Add Feynman Zhou notaryproject#235. The proposal is to abandon the above PRs and merge only this one. Signed-off-by: Toddy Mladenov toddysm@gmail.com Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
* doc: Add Yi as a notaryproject maintainer Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com> * Added CODEOWNERS and MAINTAINERS files (#240) This PR combines all the changes from the following PRs for updating the maintainers for notaryproject/notaryproject sub-project: Add Milind Gokarn #228 Add Pritesh Bandi #227 Add Shiwei Zhang #234 Add Toddy Mladenov #236 Add Vani Rao #229 Add Yi Zha #237 To keep a balance I dropped Add Feynman Zhou #235. The proposal is to abandon the above PRs and merge only this one. Signed-off-by: Toddy Mladenov toddysm@gmail.com Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com> * fix syntax error in CODEOWNERS file Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com> pick d194f78 fix syntax error in CODEOWNERS file Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com> * fix syntax error in CODEOWNERS file Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com> pick d194f78 fix syntax error in CODEOWNERS file Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com> * Added CODEOWNERS and MAINTAINERS files (#240) This PR combines all the changes from the following PRs for updating the maintainers for notaryproject/notaryproject sub-project: Add Milind Gokarn #228 Add Pritesh Bandi #227 Add Shiwei Zhang #234 Add Toddy Mladenov #236 Add Vani Rao #229 Add Yi Zha #237 To keep a balance I dropped Add Feynman Zhou #235. The proposal is to abandon the above PRs and merge only this one. Signed-off-by: Toddy Mladenov toddysm@gmail.com Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com> * chore: fix conflicts Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com> pick eaefc35 chore: fix conflicts Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com> * fix conflicts Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com> * fix git signing problem Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com> * add a new line at the end Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com> * fix syntax in MAINTAINERS Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com> --------- Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com> Signed-off-by: Toddy Mladenov toddysm@gmail.com Co-authored-by: Toddy Mladenov <me@toddysm.com>
Signed-off-by: Toddy Mladenov toddysm@gmail.com
This PR combines all the changes from the following PRs for updating the maintainers for notaryproject/notaryproject sub-project:
Add Milind Gokarn #228
Add Pritesh Bandi #227
Add Shiwei Zhang #234
Add Toddy Mladenov #236
Add Vani Rao #229
Add Yi Zha #237
To keep a balance I dropped Add Feynman Zhou #235
The proposal is to abandon the above PRs and merge only this one.