chore: fix syntax error in CODEOWNERS file #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FeynmanZhou
requested review from
toddysm,
iamsamirzon,
priteshbandi and
vaninrao10
iamsamirzon
previously approved these changes
Feb 21, 2023
toddysm
previously approved these changes
Feb 22, 2023
FeynmanZhou
changed the title
FeynmanZhou
dismissed stale reviews from yizha1, toddysm, and iamsamirzon
via
5de0a43
FeynmanZhou
force-pushed
the
main
branch
2 times, most recently
from
eaefc35
to
af87772
Compare
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
This PR combines all the changes from the following PRs for updating the maintainers for notaryproject/notaryproject sub-project: Add Milind Gokarn notaryproject#228 Add Pritesh Bandi notaryproject#227 Add Shiwei Zhang notaryproject#234 Add Toddy Mladenov notaryproject#236 Add Vani Rao notaryproject#229 Add Yi Zha notaryproject#237 To keep a balance I dropped Add Feynman Zhou notaryproject#235. The proposal is to abandon the above PRs and merge only this one. Signed-off-by: Toddy Mladenov toddysm@gmail.com Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
pick d194f78 fix syntax error in CODEOWNERS file
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
pick d194f78 fix syntax error in CODEOWNERS file
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
This PR combines all the changes from the following PRs for updating the maintainers for notaryproject/notaryproject sub-project: Add Milind Gokarn notaryproject#228 Add Pritesh Bandi notaryproject#227 Add Shiwei Zhang notaryproject#234 Add Toddy Mladenov notaryproject#236 Add Vani Rao notaryproject#229 Add Yi Zha notaryproject#237 To keep a balance I dropped Add Feynman Zhou notaryproject#235. The proposal is to abandon the above PRs and merge only this one. Signed-off-by: Toddy Mladenov toddysm@gmail.com Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
pick eaefc35 chore: fix conflicts
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
|
I fixed the git signing problem due to the branch policy changes in #226. Please review and re-approve this PR. Thanks |
iamsamirzon
previously approved these changes
Feb 24, 2023
toddysm
requested changes
Feb 24, 2023
vaninrao10
previously approved these changes
Feb 24, 2023
There was a problem hiding this comment.
@toddysm good catch on the empty line. @FeynmanZhou please take care.
Rest LGTM
|
@FeynmanZhou Is this PR still valid? Maybe we can close it. |
|
@yizha1 We need to add empty lines at the end of the file. This change was requested some time back. Once this is done, we can metge |
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
FeynmanZhou
dismissed stale reviews from vaninrao10 and iamsamirzon
via
f8b66cb
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
|
Hi @toddysm @iamsamirzon @vaninrao10 @yizha1 @priteshbandi , I resolved @toddysm 's comments. Could you pls review and approve it again? Thanks |
toddysm
approved these changes
Mar 20, 2023
justincormack
approved these changes
Mar 21, 2023
|
Maybe could squash some of this into fewer commits... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix syntax problems in CODEOWNERS and MAINTAINERS