Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character Panel: menu-item remains "checked" after closing the panel #9216

Closed
Yaron10 opened this issue Dec 1, 2020 · 3 comments
Closed
Assignees

Comments

@Yaron10
Copy link

Yaron10 commented Dec 1, 2020

Master with cfe3f3b.


STR:
Open the Character Panel.
Close it by clicking its Close button.

Result:
The menu-item remains "checked".

תמונה

Relevant to Clipboard History as well.
The issue does NOT exist in other togglable panels.

Yaron10 referenced this issue Dec 1, 2020
Make "Clipboard History" and "Character Panel" have the same behaviour of the other dockable panels.

Fix #9094, fix #9078, close #9096, close #9079
@sasumner
Copy link
Contributor

sasumner commented Dec 1, 2020

Good find.

Side note: I never noticed until now that the menu item only turns ON the character panel, and no menu checkmark appears (in 7.9.1). Maybe I'm late to the party on that. :-)

@Yaron10
Copy link
Author

Yaron10 commented Dec 1, 2020

and no menu checkmark appears (in 7.9.1).

In 7.9.1 those panels are not togglable.
cfe3f3b is a nice addition which requires some "fine-tuning".

@donho donho self-assigned this Dec 1, 2020
@donho donho closed this as completed in 59a0c7c Dec 7, 2020
@Yaron10
Copy link
Author

Yaron10 commented Dec 8, 2020

@donho,

Great. 👍
Thank you for that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants