better specify the cmdline interpreter

[xomx]

Fixes #11818 .

This solves a possible confusion between the cmdline interpreter and the possible folder named "cmd"' for the ShellExecute WINAPI.

[dail8859]

Kind of a dumb question, but what about if there is a cmd.exe file in the local directory? Is this situation even avoidable?

https://docs.microsoft.com/en-us/windows/win32/shell/app-registration?redirectedfrom=MSDN#finding-an-application-executable

The file is sought in the following locations:

    The current working directory.
    The Windows directory only (no subdirectories are searched).
    The Windows\System32 directory.
    Directories listed in the PATH environment variable.
    Recommended: HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\App Paths

[xomx]

@dail8859

Kind of a dumb question, but what about if there is a cmd.exe file in the local directory?

It is a legitimate question, ShellExecute then really tries to open any file named "cmd.exe" from the dir selected (e.g. from the "faw_test" dir example mentioned in the issue). So if somebody copies there e.g. the Windows "notepad.exe" file, renames it to the "cmd.exe", then the Windows Notepad will be opened instead of the command prompt requested.

Is this situation even avoidable?

Yes, when we use "%WINDIR%\System32\cmd.exe" instead of my current "cmd.exe". I tried that and it works ok.

But there is still something I need to understand - during my testing I have found that there is a N++ GUIConfig for this cmdline interpreter, which I cannot find in the N++ GUI or in the correspondent "config.xml": commandLineInterpreter

And at the next line is a hard-coded comparison to TEXT("cmd"), so it needs the same adjustment. I will probably create a common define for it to be used at both places.

[dail8859]

@xomx

But there is still something I need to understand

Luckily the documentation is kept up really well.

https://npp-user-manual.org/docs/preferences/#preferences-for-advanced-users

It is for advanced users that want to manually change the interpreter in the config file themselves.

[vinsworldcom]

It is for advanced users that want to manually change the interpreter in the config file themselves.

I do that:

C:\usr\bin\npp64\config.xml
115:         <GUIConfig name="commandLineInterpreter">powershell</GUIConfig>

Cheersl

[MarkusBodensee]

Kind of a dumb question, but what about if there is a cmd.exe file in the local directory? Is this situation even avoidable?

And the next one... What happens now with a folder named cmd.exe in the local directory. I think same happens like mentioned in the issue, folder opens in explorer.

[xomx]

@MarkusBodensee

Yes, the "cmd.exe" folder will be opened in the explorer.
It is interesting that when one creates both "cmd" and "cmd.exe" subfolders, the explorer opens the "cmd.exe" one.

My latest version ("%WINDIR%\System32\cmd.exe") solves even that (I checked).

[MarkusBodensee]

Better use constants in C++, instead of defines ?

const TCHAR cmdInterpreter[] = TEXT("%WINDIR%\\System32\\cmd.exe");

[xomx]

It is equivalent (the above #define... will become the same const TCHAR*).

[tarkett2018]

@xomx

Yes, when we use "%WINDIR%\System32\cmd.exe" instead of my current "cmd.exe". I tried that and it works ok.

Only a suggestion: You can also use the environment variable %COMSPEC%. Then you get directly the command line interpreter which can be different in mixed x86/x64 systems.

[xomx]

@tarkett2018

Nice, that is even better, it works ok. (x86/x64 was not a problem before - the WinOS redirector handles that for 32/64-bit apps)

I hope this is the final version, I will be computer-free until next weekend.