Firebase Token Error response handling

[CR4567]

I'm wondering about the error code handling of firebase.
See

notifo/backend/src/Notifo.Domain.Integrations/Firebase/FirebaseMobilePushSender.cs

Line 62 in ef9b635

throw new MobilePushTokenExpiredException();

There is a handling for error code "NotFound" and "InvalidArgument", but on firebase admin doc I can't find the notFound code. Instead for invalidating the token we should wait for "Unregistered". I would expect that this is the also the only response that should trigger an invalidation. All other errors are not related to the life of the token.

https://firebase.google.com/docs/reference/admin/dotnet/namespace/firebase-admin/messaging#namespace_firebase_admin_1_1_messaging_1ac3482b9d4581255dee08b81ac3f677c9

[SebastianStehle]

There is no such a code: https://github.com/firebase/firebase-admin-dotnet/blob/f6babbd4e59655f01be4a43230b5be198fc4f8cd/FirebaseAdmin/FirebaseAdmin/ErrorCode.cs

[CR4567]

This are the parent errorCodes, but there are specific for messaging.
https://github.com/firebase/firebase-admin-dotnet/blob/master/FirebaseAdmin/FirebaseAdmin/Messaging/MessagingErrorCode.cs
Shouldn't you get these codes?

[SebastianStehle]

Sorry, there was another property. I have pushed a potential fix.

[CR4567]

ok looks good. That's what I would have expected.