Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 5.0.0-pre.15 #402

Merged
merged 1 commit into from May 1, 2022
Merged

Prepare 5.0.0-pre.15 #402

merged 1 commit into from May 1, 2022

Conversation

0xpr03
Copy link
Member

@0xpr03 0xpr03 commented Apr 30, 2022

No description provided.

@0xpr03 0xpr03 requested a review from JohnTitor April 30, 2022 16:06
@JohnTitor
Copy link
Member

The only thing I'm not so fond of is that without rustc 1.56 we can't simply enforce the new MSRV, which would probably make required upgrades easier to detect for downstream.

It's totally fine to bump up MSRV to 1.56 IMO, we could also switch to edition 2021. There's no need to happen it on this release but feel free to do so.

@0xpr03 0xpr03 force-pushed the prepare_pre15 branch 2 times, most recently from cc5440c to 5b438c1 Compare April 30, 2022 20:11
@0xpr03
Copy link
Member Author

0xpr03 commented Apr 30, 2022

Ok, pushing to 1.56 actually breaks existing code due to now denied raw-pointer send/sync stuff.

Raise MSRV to 1.56 to allow for rust-version
@0xpr03 0xpr03 merged commit ae5c055 into main May 1, 2022
12 of 13 checks passed
@0xpr03 0xpr03 deleted the prepare_pre15 branch May 1, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants