-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noto Sans Arabic and Noto Naskh need Kashmiri GSUB lookups #68
Comments
Note that Noto Naskh are the older SOW12 fonts that need to be modified. |
@waksmonskiMT : owns SOW15 part |
…g Phase II fonts (and updating version numbers)
http://jungshik.github.io/noto/arabic/digits.html (I grabbed the latest versions of NotoNaskhArabic(UI) and use them as web fonts in the page) does not seem to work as expected in Chrome canary (65.x with Harbuzz 1.6.3) and Firefox 57. |
BTW, hinted fonts also need to be updated. Chrome/Chromium OS still use hinted fonts. |
I dumped GSUB tables of NotoNaskhArabic-Regular.ttf with and without Marek's change and I don't see any issue with his change. As far as I can tell, his change should work. And, Harfbuzz does map 'ks' (ISO 639 / BCP 47 lang tag) to 'KSH ' (ot language tag). |
The only potential issue is that langsys records are not sorted alphabetically. "FAR ", "SND ", "URD " and "KSH ". Perhaps, they should be. "FAR ", "KSH ", "SND ", "URD ". |
Yes, that's it. LangSys records have to be sorted. |
Thank you Jungshik! |
The previous fix (3beadb5) was incomplete. It copied LangSys entry for 'URD ' in GSUB to 'KSH ', but the entries were not sorted leading 'KSH ' not to picked up by HarfBuzz. This CL sorts LangSys entries in GSUB. It also fixes the hinted version of Noto Sans Naskh Arabic (UI) fonts. Tested at http://jungshik.github.io/noto/arabic/digits.html . Extended Arabic digits 4,6 and 7 in Kashimir should match those in Urdu and be different from those in Arabic/Persian. Extended Arabic digits 6 and 7 in Sindhi should match those in Urdu and be different from those in Arabic/Persian. Fixes #975
Extended Arabic-Indic digits 4, 6, and 7 (U+06F[467]) in Kashimiri should have the same glyphs as in Urdu. This is acheived by copying the GSUB table for Urdu(URD) to Kashimir (KSH). See http://jungshik.github.io/noto/arabic/digits.html . With these font update installed on a device, 'System font' column should be identical to two other columns in all three tables. Especially, Extended Arabic-Indic digits 4,6 and 7 in Kashimiri should match those in Urdu. Upstream bug: https://github.com/googlei18n/noto-fonts/issues/975 Upstream fixes: notofonts/noto-fonts@3beadb5d notofonts/noto-fonts#1016 Test: http://jungshik.github.io/noto/arabic/digits.html Change-Id: If136728991d0a56a4dc6400bcd1dd2749319caf9
* Update external/noto-fonts from branch 'master' to 68a449ab9b0a23ea35a90d7d62552fe748ad061b - Merge "Upstream internal changes to emoji-compat from internal master." - Upstream internal changes to emoji-compat from internal master. Test: ./gradlew assembleDebug in support library now works Change-Id: I9296d3c86b047681efc18efa5bf03be2452a131d - Merge "Add LOCAL_SDK_VERSION in noto-emoji-compat-java" - Merge "Add ability to build unbundled builds." - Add ability to build unbundled builds. This adds ability to build using jcenter instead of local prebuilts directory. This is needed for special unbundled checkouts of support library that use remote maven to get all of its dependencies. Bug: 72221688 Test: local build of support lib Change-Id: Icec568e27caa745bbf20f82c179509de1d4c2485 - Add LOCAL_SDK_VERSION in noto-emoji-compat-java The noto-emoji-compat-java is using only public API. However it is defined java:platform which can use internal API, since it is not defined LOCAL_SDK_VERSION. So, LOCAL_SDK_VERSION := current is added in noto-emoji-compat-java, because it can be turn into errors when link type check becomes more strict. Bug: 69899800 Test: mma -j under devicesidelib dir Change-Id: Ib3d4a8cf24d29ce496288cd795a065c36a161f4e - Merge "Update NotoNaskhArabic for Kashimiri" - Update NotoNaskhArabic for Kashimiri Extended Arabic-Indic digits 4, 6, and 7 (U+06F[467]) in Kashimiri should have the same glyphs as in Urdu. This is acheived by copying the GSUB table for Urdu(URD) to Kashimir (KSH). See http://jungshik.github.io/noto/arabic/digits.html . With these font update installed on a device, 'System font' column should be identical to two other columns in all three tables. Especially, Extended Arabic-Indic digits 4,6 and 7 in Kashimiri should match those in Urdu. Upstream bug: https://github.com/googlei18n/noto-fonts/issues/975 Upstream fixes: notofonts/noto-fonts@3beadb5d notofonts/noto-fonts#1016 Test: http://jungshik.github.io/noto/arabic/digits.html Change-Id: If136728991d0a56a4dc6400bcd1dd2749319caf9 - Merge "DO NOT MERGE: Merge Oreo MR1 into master" - DO NOT MERGE: Merge Oreo MR1 into master Exempt-From-Owner-Approval: Changes already landed internally Change-Id: I46001ccf398c2cfd4480ce5688176d2141010ad7 - Add checksum to emoji-compat metadata am: 1bf56f26dc am: 45de9cac69 -s ours Change-Id: Iaebaaf38e4e2e1959c5426936c6f103f930d9813 - Add checksum to emoji-compat metadata am: 1bf56f26dc Change-Id: I6445054bbd30561b2a0f4e758b72c3d9dd3eb2c0 - Add checksum to emoji-compat metadata This CL updates createfont.py script. It calculates a checksum from source emoji font, flat buffer schema and emoji metadata. Finally it embeds this checksum into font metadata. Test: ./gradlew support-emoji:connectedAndroidCheck Bug: 62024362 Change-Id: I161daa8aa9af5a767eb7d26af94e391be5187320 (cherry picked from commit ddd072a17bcb3a87600d72230132aed850a9e8ad) (cherry picked from commit 3bf771df3dc4bdb3d71c7ca3cc5aa3fdca8a4797) - Read context substitution table to create emoji metadata am: 7e10dd415c Change-Id: I1993c216ec7e0d2ea174d378073369781be5e33c - Read context substitution table to create emoji metadata createfont script updated to read the context substitution table. Current NotoColorEmoji font uses it to define the flags with question marks. Test: ./gradlew support-emoji:connectedAndroidTest Test: Ran support-emoji-demos app with one of the flags mentioned Test: AllEmojis test is updated to check if an emoji in metadata can be rendered. Bug: 65353865 Change-Id: Ic95c2c3b7f15503abc0e2528b4162a1feeb07ace - DO NOT MERGE: Merge commit '3bf771df3dc4bdb3d71c7ca3cc5aa3fdca8a4797' from oc-support-26.0-dev to stage-aosp-master. am: c1172c51af -s ours am: 98e9da10bd -s ours am: fc10ea9a51 -s ours am: 9315c0d611 -s ours am: 9790a4d878 Change-Id: Id1017144ee094dc9219c8e2935439afd87bca2b3 - DO NOT MERGE: Merge commit '3bf771df3dc4bdb3d71c7ca3cc5aa3fdca8a4797' from oc-support-26.0-dev to stage-aosp-master. am: c1172c51af -s ours am: 98e9da10bd -s ours am: fc10ea9a51 -s ours am: 9315c0d611 -s ours Change-Id: Ifa01bcdc6b6c55019f4e1aa94825e14bf08dd669 - DO NOT MERGE: Merge commit '3bf771df3dc4bdb3d71c7ca3cc5aa3fdca8a4797' from oc-support-26.0-dev to stage-aosp-master. am: c1172c51af -s ours am: 98e9da10bd am: 2cfdee9a27 Change-Id: I2aaa8c5a0a40af6f0e219f87b7f4aad779fc8a2d - DO NOT MERGE: Merge commit '3bf771df3dc4bdb3d71c7ca3cc5aa3fdca8a4797' from oc-support-26.0-dev to stage-aosp-master. am: c1172c51af -s ours am: 98e9da10bd -s ours am: fc10ea9a51 -s ours Change-Id: I3c0421ec0feb18be79cb64687d0e59de5029865a - DO NOT MERGE: Merge commit '3bf771df3dc4bdb3d71c7ca3cc5aa3fdca8a4797' from oc-support-26.0-dev to stage-aosp-master. am: c1172c51af -s ours am: 98e9da10bd Change-Id: I60d1e78d331adf0e4dff822887f2224f4b0a3f05 - DO NOT MERGE: Merge commit '3bf771df3dc4bdb3d71c7ca3cc5aa3fdca8a4797' from oc-support-26.0-dev to stage-aosp-master. am: c1172c51af -s ours am: 98e9da10bd -s ours Change-Id: I9f3e3768ff9ca6104a1f8998c8de1c794da3e1a8 - DO NOT MERGE: Merge commit '3bf771df3dc4bdb3d71c7ca3cc5aa3fdca8a4797' from oc-support-26.0-dev to stage-aosp-master. am: c1172c51af -s ours Change-Id: I0e3f81832d855e95727c71f034b72643d19bb9ae - DO NOT MERGE: Merge commit '3bf771df3dc4bdb3d71c7ca3cc5aa3fdca8a4797' from oc-support-26.0-dev to stage-aosp-master. Bug: 64219148 Test: build Change-Id: I4db03ec695b0f4da398a16f76227890665060848 - Add checksum to emoji-compat metadata am: 3bf771df3d am: fc30b06dcd Change-Id: I4be6f94a9da54294b4f5aedee5848ae341006419 - Add checksum to emoji-compat metadata am: 3bf771df3d Change-Id: I0d5fa3e9938ecd3bf490ed2fa89b7a316576aaf5 - Add checksum to emoji-compat metadata This CL updates createfont.py script. It calculates a checksum from source emoji font, flat buffer schema and emoji metadata. Finally it embeds this checksum into font metadata. Test: ./gradlew support-emoji:connectedAndroidCheck Bug: 62024362 Change-Id: I161daa8aa9af5a767eb7d26af94e391be5187320 (cherry picked from commit ddd072a17bcb3a87600d72230132aed850a9e8ad) - Merge "Add checksum to emoji-compat metadata" - Set Java version to be 1.7 for emoji-compat library. am: f1dc07e135 am: ee2608287c Change-Id: Ie2ba2f70df8901aaf3a2bcf13cc9c0b3a2754b83 - Set Java version to be 1.7 for emoji-compat library. am: f1dc07e135 Change-Id: I0f8132a70018a06e39705d6a1d55a5288e5cf6a8 - Set Java version to be 1.7 for emoji-compat library. Test: ./gradlew uploadArchives, extract emoji-compat aar, look at libs/noto-emoji-compat-java.jar, extract it, run javap -v MetadataItem See major version: 51 (instead of 52 that was ther before) Bug: 62682795 Change-Id: I49072912448c8804d8fef558fc12eaec46996515 (cherry picked from commit 345cae1c459d28af15ac2010ad1cf987993ef394) - Set Java version to be 1.7 for emoji-compat library. Test: ./gradlew uploadArchives, extract emoji-compat aar, look at libs/noto-emoji-compat-java.jar, extract it, run javap -v MetadataItem See major version: 51 (instead of 52 that was ther before) Bug: 62682795 Change-Id: I49072912448c8804d8fef558fc12eaec46996515 - Add checksum to emoji-compat metadata This CL updates createfont.py script. It calculates a checksum from source emoji font, flat buffer schema and emoji metadata. Finally it embeds this checksum into font metadata. Test: ./gradlew support-emoji:connectedAndroidCheck Bug: 62024362 Change-Id: I161daa8aa9af5a767eb7d26af94e391be5187320 - Clean up the jarjar task invocation in noto-emoji-compat This change makes jarjar task cachable and removes a number of redundant tasks. Test: ./gradlew support-emoji:assemble Change-Id: Iafb1fbf9340b3d9dab02b7c732f96ba105b5b862 - Merge "Update NotoColorEmojiCompat font am: 43f0134ffe am: 0bc8b9746e" into oc-dr1-dev-plus-aosp am: d350b406cb Change-Id: I66cf16216b4f2977ebaa58740ab8f5ba2540fa1f - Update NotoColorEmojiCompat font am: 43f0134ffe am: a25a462f02 am: 66469ff29f Change-Id: I1c525d4bfef9d293b15b98e6ac7e6c40f36f9381 - Merge "Update NotoColorEmojiCompat font am: 43f0134ffe am: 0bc8b9746e" into oc-dr1-dev-plus-aosp - Update NotoColorEmojiCompat font am: 43f0134ffe am: a25a462f02 Change-Id: I0d8c489441d9e5f3dd025613c5a134daee8b579e - Update NotoColorEmojiCompat font am: 43f0134ffe am: 0bc8b9746e Change-Id: I75fd2080c59544ba875eac58382a3b84f70258d9 - Update NotoColorEmojiCompat font am: 43f0134ffe Change-Id: I4407fc28778059afd8cabb27817663a81ce4692a - Update NotoColorEmojiCompat font am: 43f0134ffe Change-Id: If464d2a83708abec300762fca2950c0061371de4 - Update NotoColorEmojiCompat font Update NotoColorEmojiCompat font with changes made to NotoColorEmoji in I0c11b4582929147cb938c8c0860bc297b8b587aa Test: ./gradlew clean support-emoji:connectedAndroidTest Bug: 62658677 Change-Id: I70bb58d254e52663b4f7a23f6bbfbb33bcf60b91 - Update color emoji font with latest images. am: 6b3b33bae3 am: 0589faa609 am: aa9a1af6f7 Change-Id: I918d1ff66130e1229df4c85c43585fec8cdf8a17 - Update color emoji font with latest images. am: 6b3b33bae3 am: cd594617e1 am: d35c1df489 Change-Id: Id0f625420cd1777c218b5b164c1ca705eb5eec04 - Update color emoji font with latest images. am: 6b3b33bae3 am: 0589faa609 Change-Id: Iea09ed07d12d1b1e226c287e64706a19efcf4f60 - Update color emoji font with latest images. am: 6b3b33bae3 am: cd594617e1 Change-Id: I2d136838658fa7f23940f403a2af702efa38ca0c - Update color emoji font with latest images. am: 6b3b33bae3 Change-Id: I33dea473774af6f34ba5d6712dedc2dd27d52867 - Update color emoji font with latest images. am: 6b3b33bae3 Change-Id: Ib96e0fc1e75997b3a102b41749206286bf56458a - Update color emoji font with latest images. Change-Id: I0c11b4582929147cb938c8c0860bc297b8b587aa Fixes: 37778978 fixes to blushing emoji Fixes: 62065580 man/woman pouting looks like people with mustache Fixes: 37276533 grinning face with smiling eyes does not convey correct emotion Fixes: 62024261 "Pound" symbol incorrect - should have only one line across Fixes: 62025932 Nerd face fixes Fixes: 62024767 Monocle needs to look condescending Fixes: 62031661 Holding hand emoji need more detail in arm and hands Fixes: 62132164 Fixes to rabbit and rabbit face emoji Fixes: 62082098 Key doesn't match keyhole Test: visual inspection of images on web page - Merge "Update emoji-compat build to use flatbuffers source" into oc-dev am: da9886aeec am: 4d5cfce4b9 Change-Id: Idbdd9dff467ea66eb3e15f14c5c0c4fdeb8ecb50 - Merge "Update emoji-compat build to use flatbuffers source" into oc-dev am: da9886aeec Change-Id: I068f99b5f8907ef558ef19791af49b1653ad28f6 - Merge "Update emoji-compat build to use flatbuffers source" into oc-dev - Merge "Revert "Update emoji-compat build to use flatbuffers source"" into oc-dev am: b8f325704c am: d1c6a008a2 Change-Id: I4a2aa516ace6c446e110542af1a904bb90225910 - Update emoji-compat build to use flatbuffers source Initial commit I6c0387307c4e470404bd4e9cc4f8262f6e5335d7 broke docs target. This CL adds noDocs property in build.gradle on top of initial commit. Test: mmm external/noto-fonts/emoji-compat ./frameworks/support/gradlew -p frameworks/support \ support-emoji:connectedAndroidTest ./gradlew generateDocs Bug: 36043651 Change-Id: I8dd2a9b7d61abd1a32ac862917062559071da944 - Merge "Revert "Update emoji-compat build to use flatbuffers source"" into oc-dev am: b8f325704c Change-Id: I93b0de74716d2ce6e31e4f925508049a1346d39e - Merge "Revert "Update emoji-compat build to use flatbuffers source"" into oc-dev - Revert "Update emoji-compat build to use flatbuffers source" Breaks generateDocs target. This reverts commit 85d9741e58978f93020f71ab025de78c9c082ec8. Change-Id: Ia2494fb89c6e54e3f0911a71650a176668e93f48 - Merge "Update emoji-compat build to use flatbuffers source" into oc-dev am: 7871808d82 am: 301cd90933 Change-Id: Iaa1f0825eadccd978af67aae7ebc4c25efc053a2 - Merge "Update emoji-compat build to use flatbuffers source" into oc-dev am: 7871808d82 Change-Id: Ic0be4837ac3b9349061bd92aff6d7b152b6d2789 - Merge "Update emoji-compat build to use flatbuffers source" into oc-dev - Revert Hebrew sans-serif fonts to Noto phase 2 versions [DO NOT MERGE] am: 393d25f009 am: d4884c0d70 Change-Id: I048a310133f8aa24cb2c1d983e510b9aad3aa5a0 - Revert Hebrew sans-serif fonts to Noto phase 2 versions [DO NOT MERGE] am: 393d25f009 Change-Id: Ibed35db9a59638fdd811df201807602815316fa3 - Revert Hebrew sans-serif fonts to Noto phase 2 versions [DO NOT MERGE] Bug: 38039841 Bug: https://github.com/googlei18n/noto-fonts/issues/909 Test: none Change-Id: Ie9b3396dd45d6da05188371c25b53322437c115f - Lighten flag colors in Emoji font. am: c59d154a1d am: a2b17051e1 Change-Id: I177074f62b3efaf8d271fddb2e8c48f894bcf37b - Lighten flag colors in Emoji font. am: c59d154a1d Change-Id: If14c097be658822de3230674ae2fbfc543f63d98 - Lighten flag colors in Emoji font. The flags have a shadow effect, the change lightens them a bit so this should be better. Because of the shadow effect the brightness will vary across the image. Tested the Russian flag using Gimp color picker. Also did a side-by-side comparison of all the flags, they all look a little bit lighter. Updated version number in README.android. Change-Id: Ic761858f2afe848b08370334e14cc23745cb35b0 Fixes: 37375651 The Russian flag emoji has an incorrect blue color Test: visual inspection - Add build.gradle to noto-fonts/emoji-compat am: ddbe01bad1 am: 3c68de1ea4 Change-Id: I492c14a8588d49cb02a9d534dd69b897c8427349 - Add build.gradle to noto-fonts/emoji-compat am: ddbe01bad1 Change-Id: I8e05c87696ce273a213d7e550750de87ac9f2f05 - Update emoji-compat build to use flatbuffers source Test: mmm external/noto-fonts/emoji-compat ./frameworks/support/gradlew -p frameworks/support \ support-emoji:connectedAndroidTest Bug: 36043651 Change-Id: I6c0387307c4e470404bd4e9cc4f8262f6e5335d7 - Add build.gradle to noto-fonts/emoji-compat Create a fat jar for parsing emoji-compat font. The build is updated to include flatbuffers classes into final jar, and also repackages them using jarjar. This way users of the jar can just reference to the final artifact instead of referencing source codes and flatbuffers jar separately. Test: ran ./gradlew assemble ran ./createfont.py ../emoji/NotoColorEmoji.ttf ../../unicode/ Visual inspection of new jar content. Bug: 37477831 Change-Id: I028f0bed9d9dbea6476ea11ac356faecbc3eb3e8 - Remove control chars from NotoSansCJK. am: e2babb9624 am: 5591e0032a Change-Id: Ide4210b8c970ee89897b94f18a894668e95a6fe4 - Remove control chars from NotoSansCJK. am: e2babb9624 Change-Id: Ie71dc4ca536638b72561f653499c84f2c3773749 - Remove control chars from NotoSansCJK. NotoSerifCJK is ok w.r.t. ASCII controls, it does not map them. Change-Id: I9ffbfb6c35998409687f6a1bf2ea0f173b262898 Fixed: 21569710 Test: inspected cmap - Merge "Add Noto Serif CJK to source tree." into oc-dev am: 079c0b3bf0 am: cec1907a3e Change-Id: Ib55c458bd39858d819c35de96e41d0ea454f301a - Merge "Fix bug in Naskh Regular diacritics." into oc-dev am: 510318ded6 am: 8b26e413c1 Change-Id: Ifc89277267118ac65265af29253f448646bc1ee2 - Merge "Add Noto Serif CJK to source tree." into oc-dev am: 079c0b3bf0 Change-Id: I818be82ec1c4499f909d818b3f4d5dc3dc7d00fb - Merge "Fix bug in Naskh Regular diacritics." into oc-dev am: 510318ded6 Change-Id: I1e1ca45a5954e88944d9f508a626ee2b55c0aab1 - Merge "Add Noto Serif CJK to source tree." into oc-dev - Merge "Fix bug in Naskh Regular diacritics." into oc-dev - Add Noto Serif CJK to source tree. The font is currently unused. Some characters were removed from the upstream font using the subset_noto_cjk.py tool. This tool was also modified a bit since originally it subset only the Sans CJK font, and the name of the nototools utility function it used had changed. Change-Id: Ia69390c1fdc9b4741fcf91fa37f9f5a3c108d5b4 Fixes: 37284486 Add Noto Serif CJK into Android source tree Test: none. verified slight size reduction after emoji removal. - Update emoji-compat font am: 9f24f25c80 am: 82e04816e8 Change-Id: Ic57dde11bbe4b811d83deb9a3b249a832dc3042e - Fixes to NotoColorEmoji am: 863ce7b150 am: 34d5840a13 Change-Id: I47db03da21d2ac7ca9972091accb14bfc0d5a650 - Update emoji-compat font am: 9f24f25c80 Change-Id: I4d79e51fa0e72cf7bcbe55a98af0bf68a7eaa0d9 - Fixes to NotoColorEmoji am: 863ce7b150 Change-Id: Ia5ac56d9065ddda904ac62b9ecd67dab060b6942 - Update emoji-compat font Updates the emoji-compat font according to the latest NotoColorEmoji. It also fixes the history of wrestler and handshake skin tone emojis. The font is based on the change b7ad3a2d57b9b527e7cf423cce9bb762aa9a5ee8 Test: ran ./gradlew support-emoji:connectedAndroidTest in support library project Bug: 37512440 Change-Id: I2c0d8f2460fb6bd6a9569b63e6c8cb251374e016 - Fixes to NotoColorEmoji Version number updated to 1.37. - includes emoji design changes through 4/23. - grayscale fixes - restores support for deprecatd skin tones of wrestler and handshake - lots of small image fixes - compression adjustments make font a bit smaller Change-Id: Ib7ad3a2d57b9b527e7cf423cce9bb762aa9a5ee8 Fixes: 37343104 blonde eyebrows Fixes: 37351768 penguin beak Fixes: 37351771 shrimp antennae Fixes: 37351638 pita/burrito swapped Fixes: 37351781 sushi too small Fixes: 37353458 needle should face right Fixes: 37353416 U+2626 bottom bar is too long Fixes: 37353485 SOS text should be bigger Fixes: 37353451 U+1F4C0 should be golden Fixes: 37351482 necktie needs rest of shirt Fixes: 37325697 ant should be bigger Fixes: 37203609 fog (U+1F32B) should look like other vendors Fixes: 37207140 skin tones for wrestlers and handshake Fixes: 37352276 crying face should have vertical tear Fixes: 37192751 technology emoji too dark Fixes: 37203074 ROTFL should lean left Fixes: 37276533 U+1F601 (grin/smiling eyes) emotion Fixes: 37168239 U+1F3EE red lantern should not have text Fixes: 37168729 U+1F6D1 stop sign should not have hand Fixes: 37191845 wrestlers and handshake show fitzpatrick patch Fixes: 37219171 female mage U+1F9D9 should have white hair Fixes: 37277409 U+1F623 persevering face Fixes: 37218687 U+1F683 Jack-o-lantern smile Test: visual inspection using emoji html review page - Fix bug in Naskh Regular diacritics. Change-Id: I8589196099356b2fb0b81374496edad42414d222 Fixes: 37509523 Test: viewed sample text with hb-view - Merge "Move emoji compat font under external/noto-fonts" into oc-dev am: 18a519961f am: 6ea12be4cd Change-Id: Ied27a0ca75f57547b73866b3c29872f265554f6b - Merge "Move emoji compat font under external/noto-fonts" into oc-dev am: 18a519961f Change-Id: Id0f96c28b08988cf62f7f26646dca0b9ba204f8d - Merge "Move emoji compat font under external/noto-fonts" into oc-dev - Move emoji compat font under external/noto-fonts Moved the font generation logic and the final assets under external/noto-fonts/emoji-compat. All final assets including the java files that are used to parse the FlatBuffers binary data are generated under this directory. Test: ./createfont.py ../emoji/NotoColorEmoji.ttf ../../unicode/ Copied the font generated under support/emoji/core/tests/assets and ran ./gradlew support-emoji:connectedAndroidTest Bug: 36385743 Change-Id: If8ee47946a80abefc38da7667e4da300c5c7e591 - Update Noto fonts to latest upstream am: 74d42ad6fa am: becf64fb0d Change-Id: I5b6b6ac73b67552a51097718a100514944e49e9a - Update Noto fonts to latest upstream am: 74d42ad6fa Change-Id: Ifae54eae89c5e51d86827aba398b8132b5a853db - Update Noto fonts to latest upstream Updated fonts shipped with most Android images: 1. Noto Naskh Arabic UI has location of hyphens adjusted to correct height. 2. Lowercase Cherokee letters and combining marks are added to Noto Sans Cherokee. 3. Noto Sans Hebrew and Noto Sans Armenian are updated to Noto Phase 3 fonts that fix various design and technical issues. Added or updated fonts that are not shipped in Android images, but are only provided in case OEMs want to ship them are Nastaliq Urdu, Serif Armenian, Serif Bengali, Serif Devanagari, Serif Gujarati, Serif Hebrew, Serif Kannada, Serif Malayalam, Serif Tamil, Serif Telugu. Khmer and Symbols are untouched by this change, as they have recently been updated. Bug: 33441434 Bug: 26604030 Bug: https://github.com/googlei18n/noto-fonts/issues/396 Bug: https://github.com/googlei18n/noto-fonts/issues/444 Bug: https://github.com/googlei18n/noto-fonts/issues/858 Test: standard Noto lint/inspection tests. Change-Id: I3d5df5b03f2e3f6bb3b580c5afb588e03f1ca928 - Add Adlam joined font. am: 3c38bcb57e am: bb075a90d9 Change-Id: I360c58cd9239f0fa9b54369fa667383e259900e9 - Add Adlam joined font. am: 3c38bcb57e Change-Id: I0d6c9c99e6ae69e3018df6ab38eec251937b552d - Add Adlam joined font. Also include unjoined, though it's not used. Change-Id: Ia205bdafeb82c55e7e1d67d5cee80f574d4227e5 Fixes: 37156487 Test: manual review, noto lint. - Update emoji font with new design. am: 7c0ef585f2 am: d24070d3dc Change-Id: I4a3111d10c1868964784da84e7fe2549955f4024 - Update emoji font with new design. am: 7c0ef585f2 Change-Id: Ie17b50a3886acdb39a07191adfb9540d335176b8 - Update emoji font with new design. Version number bumped to 1.35. - adds new Unicode 10/Emoji 5 emojis. - supports flags of England, Scotland, and Wales. Other subregion-like sequences map to the unknown-flag glyph. - provides golfer emoji with skin tones. Change-Id: I206c649920105bb8346d3a4b94e21d9b6bc0659a Fixes: 34688862 Fixes: 33276970 Fixes: 34738377 Test: inspected with generated html page. - Use external data file for Android emoji additions am: f8f3402594 am: cd9041443d Change-Id: Idaccf35898ee65c0895d2976dd78bd58ede0d2e4 - Use external data file for Android emoji additions am: f8f3402594 Change-Id: Ib0652232afa6a3c020ac3e5112052bc36e7a1299 - Use external data file for Android emoji additions Previously, the data for Android default emojis were kept in the source file. Now they are read from a central data file. Also removed one-off characters explicitly listed that are now in the included ranges. Test: Ran the script and got identical results as before Bug: 36536216 Change-Id: I966664358bf747d600d199958baa9a8055b9aef0 - Add NotoSansKhmer VF am: 0fcf1debba am: 840eb34e34 Change-Id: I0495e3b47c46115cd85163890af5c6810aa68ec5 - Add NotoSansKhmer VF am: 0fcf1debba Change-Id: I35123c79843a476edd282b7d81d681f22499bad1 - Add NotoSansKhmer VF NotoSansKhmer-VF is added to other_vf directory along with its own README.android and NOTICE (OFL 1.1.). The total size is increased by 59,864 bytes (= 143,484 - 83,620), but VF adds a much wider weight range coverage as well as a range of widths. NotoSansKhmer-{Regular,Bold}.ttf (2 fonts) are static instances generated by the same fontmake pipeline used for VF files. They're kept in the tree for use by configurations without variable font support. For all three font files, post table version is changed to 3.0 from 2.0 by dropping psnames and extra_names entries and cmap table with PID=0/EID=3 is dropped. For the VF font, name table entries with PID=1,EID=0 were dropped. See googlefonts/fontmake#280 . BUG: 22667753 Test: See the QA instruction in the comment 10 of the bug Change-Id: Iddbd7433124d781660a0fd61872629722c11f1b1 - Add the rest of Noto Symbols Update the subsetting scripts to add the rest of symbols in Noto Sans Symbols to the first subset. Three interlinear annotation characters (U+FFF9..U+FFFB) are still skipped, to reduce the chances of them breaking something. Test: Not needed Bug: 32046261 Change-Id: Ia98b7a6ee4e31ccff7e8506a9b9b3464f133c081 - Update the subsetting script for Noto Sans Symbols The symbols subsetting script had fallen out of sync with the actual fonts it generated. This CL adds the Japanese TV symbols that were already included in the subset, and moves away from an explicitly-included default emoji list to the one coming from nototools' unicode_data. We also add all default-emoji characters that we are removing from the symbols font to the second subset, so they can be accessed using text variation sequences or setting the text language to request non-emoji forms. Note that although text variation sequences are not defined for all of those characters, they may get added in the near future and even if they don't, Android has other ways of requesting non-emoji forms. Also update the subsetted fonts by running: ./subset_noto_sans_symbols.py NotoSansSymbols-Regular.ttf \ NotoSansSymbols-Regular-Subsetted.ttf \ NotoSansSymbols-Regular-Subsetted2.ttf The first font is not changed except for time stamps, but the second now includes various new characters. Bug: 27531263 Bug: 32046261 Test: Dumped the fonts using ttx and diffed them Change-Id: Iaf3f8b38feef05d48b9f8b8712f0b9f857109d0f - Add Noto fonts for 25 historic scripts to the build Fonts for Avestan, Brahmi, Carian, Cuneiform, Cypriot, Deseret, Egyptian Hieroglyphs, Gothic, Imperial Aramaic, Inscriptional Pahlavi, Inscriptional Parthian, Kaithi, Kharoshthi, Linear B, Lycian, Lydian, Ogham, Old Italic, Old Persian, Old South Arabian, Old Turkic, Osmanya, Phoenician, Shavian, and Ugaritic have been added to the build for the largest font footprint. Test: Manual Bug: 32046261 Change-Id: If17e0480470e285323e6c93690fb1fedba08c3e0 - Include fonts for six more scripts Fonts for Phags-pa, Runic, Samaritan, and Tagalog are added, as well as two new styles for Syriac (Estrangela was already included, Eastern and Western are added). Bug: 29535549 Bug: 32046261 Test: The fonts were manually checked to be included on the device Change-Id: I930ff6f8cf29342e3aaa6042bccb341796b6620c - Move Emoji, CJK, Devanagari, Thai to SMALLER_FONT_FOOTPRINT This includes the Noto Color Emoji, Noto Sans CJK, Noto Sans Devanagari, and Noto Sans Thai fonts in the SMALLER_FONT_FOOTPRINT builds. Previously, they were excluded from such builds. Bug: 31854008 Test: make fontchain_lint Change-Id: I51c40b0959453ed39a7ea64ef078173e2cb17f60 - Move Noto Color Emoji to its own subdirectory Mostly because it has a different upstream, so it's cleaner to track the upstream and its version separately. Change-Id: I32a702702572ca840442968ac3ae8d9af2d067ac - Merge "Remove default-emoji characters from Noto CJK [DO NOT MERGE]" into nyc-mr1-dev am: 599bd2666e am: 6bc0c988c3 am: 60e126f1c0 -s ours Change-Id: Ica0ad529d808e8fa52ec0c4f8088e056df106806 - Remove default-emoji characters from Noto CJK [DO NOT MERGE] am: 51f0831a09 am: 15ba2df3d1 am: 545a111093 -s ours Change-Id: I0464f79f9ed043032e2ef24a8e43871574135afc - Merge "Remove Android's default emoji characters from Noto Serif [DO NOT MERGE]" into nyc-mr1-dev am: 7d9f678d09 am: f751a98ae6 am: 4c1d4aea96 -s ours Change-Id: I4e4afd2baada4084818746bc1f03efa509592a67 - Remove Android's default emoji characters from Noto Serif [DO NOT MERGE] am: f83342502e am: 63a2c61d3f am: 3f7cfe23ab -s ours Change-Id: I890198ee3297e917630b93c7220fa8a0dd1dec7a - Update NotoColorEmoji.ttf with single-parent families, more professions. am: 1e75a5582b am: f66081ec89 am: bc0c37417d Change-Id: I3c90e9d3b30ac1e7313db75cca6d3f8431d2e0f4 - Update NotoColorEmoji.ttf with single-parent families, more professions. Also: - updates a number of the skin tone variants to reduce unwanted differences - adds some more professions, with gender variants - aligns default (non-gender-specific) emoji with one or the other of the two gender-specific variants, where they exist. Bug: 30594617 Change-Id: I5b32f65d9bb31a23ae91e14ed100bac49e157036 - Change ascent and descent of Noto Serif to match Roboto This restores the adjustment in vertical metrics in I61e104c32e01cb86449f76dc6249bec9d96a2e4d that was mistakenly reverted in Iab359863f11c8afe886ed4b3f2aab76e3650ecb9. Bug: 19791102 Change-Id: I1e42623a349e8121eab23ffad66e3315f3997ed4 - Fix license and metadata for Noto non-CJK fonts am: d6862add00 am: 0092ce68ae Change-Id: I11a18c27d7446051f027f4c9a08982d25600c8bc - Merge "Remove default-emoji characters from Noto CJK" - Remove default-emoji characters from Noto CJK Also, the script originally written by Doug Felt for subsetting the Noto CJK font collection has been extended and modified into a form that can be run stand-alone. Bug: 30379358 Change-Id: I7f7a627096ae3762cecb0bdcfa0ad985e71e160e - Remove Android's default emoji characters from Noto Serif Previously, various characters were supported by the Noto Serif family, causing characters that we want to render in emoji style by default in Android to render in monochrome. The script subset_noto_serif.py is used to subset the fonts. Bug: 30379358 Change-Id: I25b71dd03c9c13026eb7fd39b33f9837c0a66724 - Update NotoColorEmoji.ttf with gendered professions, rainbow flag am: 5b916c0273 am: 912157a07c Change-Id: Ie26534dd097214bd05f51409ab5decb295d6ad65 - Update NotoColorEmoji.ttf with gendered professions, rainbow flag Also - adds male, female, and aesculapius emoji. - updates calendar emoji to show July 17th as the date. - adds gendered versions of 'woman with bunny ears' - remove unwanted flag - mark additional characters as emoji variants This commit is version 1.33 of the font. A previous version (1.32) had missing entries in the format 14 cmap table. bug: 29939737 Change-Id: I0e01b6eccb915b1b4a6eb1bd6ff69951ee06cc15 - Revert "Update NotoColorEmoji.ttf with gendered professions..." This reverts commit 25357cde371b716a4b8dcfd3b2c1b129f014b446. Change-Id: If7e7a8e46d24ed2279a038fcc353bf6ba663b0af - Update NotoColorEmoji.ttf with gendered professions, rainbow flag. Also - adds male, female, and aesculapius emoji. - updates calendar emoji to show July 17th as the date. - adds gendered versions of 'woman with bunny ears' - remove unwanted flag bug: 29939737 Change-Id: Ied561b117807507a76a602d485cec08c5a261607 - Adjust background color of U+1F47F am: 778dd4d1a3 am: f57026f635 am: cd5de4a19e Change-Id: I80e566c57b386e8d4c7b3094fd5436e6afccbf76 - Adjust background color of U+1F47F am: 778dd4d1a3 am: ac2a2e4be2 am: bd8b483da0 Change-Id: Ibd551af8d6a28f5aadec3062f8475544f33b099a - Update NotoColorEmoji to improve visibility against keyboard background. am: d964a9dd78 am: e10b3380af am: d47db59db9 Change-Id: I6510a7b946cf046278728dbf51961d6bb6364f4a - Update NotoColorEmoji to improve visibility against keyboard background. am: d964a9dd78 am: 3770e7cb7b am: 10f4414be2 Change-Id: I34b4b7ce64f585c85f17ecb67f1d54ffdc54e57e - Merge "Remove rifle emoji (1F946) from font. am: 63c215eb63 am: b87736c84e" into nyc-mr1-dev-plus-aosp am: a63e98c533 * commit 'a63e98c533d720438a8c8866ced42abf1a150073': Change-Id: I6c297e4c0e55124ab83e2f3c5345f64cd5ea4007 - Remove rifle emoji (1F946) from font. am: 63c215eb63 am: 0cafdc3f89 am: 4ea214f0fe * commit '4ea214f0fe1a101db1e39d3d34e6b48615a2aa05': Remove rifle emoji (1F946) from font. Change-Id: Iabb0e5df6925bd4380ae016dc8cac09b5789b7fb - Merge "Update NotoColorEmoji with latest hotfixes. am: f2a39cb1b0 am: 9560f1962f" into nyc-mr1-dev-plus-aosp am: 31cddab273 * commit '31cddab2730be25f9c50271d2aa4ab31fb82c63b': Change-Id: I1ba48d5281c26303d8fe30f7619b7ad1653f3a08 - Update NotoColorEmoji with latest hotfixes. am: f2a39cb1b0 am: 418db72ba6 am: c887c1dd52 * commit 'c887c1dd5286f85e993667ce98b665d328e4739d': Update NotoColorEmoji with latest hotfixes. Change-Id: I7ad4c809b6321a93427da76e141ca9f4f4c7b012 - Add Japanese TV symbols to subsetted Noto Symbols. am: 9249e18 am: 25ea971 am: e4c4dbf * commit 'e4c4dbf512705682d19dcfaaf5a5d56abf04b42c': Change-Id: If5853a7d2296d53d3269936567e45a8170f11f17 - Add Japanese TV symbols to subsetted Noto Symbols. am: 9249e18 am: 5b80878 am: 5a49cde * commit '5a49cde3c91a16f5bb75d6088e31d39992836b4f': Add Japanese TV symbols to subsetted Noto Symbols. Change-Id: I200e5fa79503658ad0f9ac4e1943c3abe481be63 - Move some symbol characters from Subsetted to Subsetted2. am: 8b17543 am: b62ab97 am: 118e62d * commit '118e62d4debe0718b4509ac99a908a13435791e6': Change-Id: I125e12f48c1fa4971de68eef2c418cdf9b729bf0 - Move some symbol characters from Subsetted to Subsetted2. am: 8b17543 am: 7bd2264 am: 1ad4614 * commit '1ad46147ebede1fec12e0d0befa391cffd741524': Move some symbol characters from Subsetted to Subsetted2. Change-Id: Ib5ca8ef083e9a88ba764874c6b0a7453282175e1 - Update NotoColorEmoji with hotlist fixes. am: e59f494 am: 472ff23 am: 2a2ca28 * commit '2a2ca28f211ae02d9a08d33702cb1726999ba4f9': Change-Id: Id23bf57ca304c668c7905c23ed70537f970cd70d - Update NotoColorEmoji with hotlist fixes. am: e59f494 am: 0257b7d am: 199252a * commit '199252ab5151cf9a56068fdb8424b99d2ffe5fa0': Update NotoColorEmoji with hotlist fixes. Change-Id: If818832362be7dc3ec98bb46bc64507e404c9534 - Update makefiles for new fonts. am: bfb65f2 am: 9bddb00 * commit '9bddb005ff6b627ead281a8f25a5f9f63b9c42bf': Update makefiles for new fonts. Change-Id: Ida2f404acfb4dc7019ed1b66d45d8e499619f562 - Update NotoColorEmoji with latest images am: 65d613f am: 659fa91 * commit '659fa9143bb523c9d96b3a4b44074e94dea38e35': Update NotoColorEmoji with latest images Change-Id: I25aa77866df6ef981e670b70add4f1db7b018923 - Update CJK ttc font with latest fixes. [DO NOT MERGE] am: 3f14c20 -s ours * commit '3f14c20520c96efaebb76d1df14bd246afc0098e': Update CJK ttc font with latest fixes. [DO NOT MERGE] - Update CJK ttc font with latest fixes. This fixes noto-cjk bugs 25 and 32. Emoji were stripped by unpacking the fonts and removing their cmap entries, then repacking them into a ttc. The glyphs were not removed from the fonts because doing so causes fontTools to optimize the font tables independently for each font, preventing table sharing in the ttc and maxing it significantly (about 4x) bigger. The following code was used to edit the tables. AFDKO's otf2ttc tool was used to rebuild the .ttc via ttc_utils. Bug: 26153752 Bug: 26862061 (partial) --------- from fontTools import ttLib from nototools import font_data def _remove_from_cmap(infile, outfile, exclude=[]): font = ttLib.TTFont(infile) font_data.delete_from_cmap(font, exclude) font.save(outfile) EMOJI = ( [0x26BD, 0x26BE, 0x1F18E] + range(0x1F191, 0x1F19A+1) + [0x1F201, 0x1F21A, 0x1F22F] + range(0x1F232, 0x1F236+1) + [0x1F238, 0x1F239, 0x1F23A, 0x1F250, 0x1F251] ) names = ['NotoSans%sCJK%s-Regular.otf' % (m, v) for m in ['', 'Mono'] for v in ['jp', 'kr', 'sc', 'tc']] for filename in names: print '%s...' % filename _remove_from_cmap(filename, 'no-emoji/' + filename, exclude=EMOJI) --------- from nototools import ttc_utils filenames = ['no-emoji/NotoSans%sCJK%s-Regular.otf' % (m, v) for m in ['', 'Mono'] for v in ['jp', 'kr', 'sc', 'tc']] ttc_utils.build_ttc('NotoSansCJK-Regular_new.ttc', filenames) Change-Id: Iaa8f36abe895f6b095646a0b47d3df3ba6716d39 - Revert "DO NOT MERGE Revert color emoji font to M MR1 state" am: e78ec61bcc -s ours * commit 'e78ec61bcce69b2cbff6663849a300cabb573fe9': Revert "DO NOT MERGE Revert color emoji font to M MR1 state" - DO NOT MERGE Revert color emoji font to M MR1 state am: a20f7d6b29 -s ours * commit 'a20f7d6b2907822fe0de716fc7a025ffed59ef29': DO NOT MERGE Revert color emoji font to M MR1 state
Noto Sans Arabic (alpha?) and Noto Naskh need Kashmiri GSUB lookups for digits. The digit forms used in Kashmiri are identical to the Urdu forms, so the GSUB information can simply be copied from Urdu.
This is very important for users in India, since Kashmiri is one of the scheduled/official languages of India.
The text was updated successfully, but these errors were encountered: