Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare dependency on base64 #114

Closed
Earlopain opened this issue Dec 23, 2023 · 1 comment
Closed

Declare dependency on base64 #114

Earlopain opened this issue Dec 23, 2023 · 1 comment

Comments

@Earlopain
Copy link

Ruby 3.3 which will be released pretty soon has added a warning for using base64 without declaring it since it will be removed as a default gem in Ruby 3.4. See https://github.com/ruby/ruby/blob/fe9e57bac8ec73ad822c1b245376a6cd96139ccb/NEWS.md#stdlib-updates for more details.

Currently there will be no warning for this gem I believe because it depends on both activesupport and faraday which declare base64 as their dependency. Faraday will likely remove this dependency with lostisland/faraday#1541, leaving only activesupport. For future compatibility, should both remove their reliance on the base64 gem, it should be declared here as well.

@nov
Copy link
Owner

nov commented Jan 3, 2024

OK, I prefer this approach than lostisland/faraday#1541, cedarcode/webauthn-ruby#402 etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants