Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not closing PHP ?> is considered better practice #2

Closed
ibes opened this issue Nov 14, 2021 · 2 comments
Closed

Not closing PHP ?> is considered better practice #2

ibes opened this issue Nov 14, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ibes
Copy link

ibes commented Nov 14, 2021

Hi there,

cool tool.
Seems to be just as much as needed to have a gallery. I like that style and love that I am able to get every line of the code as it is few enough lines to understand everything.

A small hint:
Not closing the PHP tags is considered better practice as it avoids the risk of having whitespace after them.

@david-novafacile
Copy link
Contributor

Thank you very much! That is a good point and will be considered in the next version.

@david-novafacile david-novafacile self-assigned this Nov 16, 2021
@david-novafacile david-novafacile added the enhancement New feature or request label Nov 16, 2021
@david-novafacile david-novafacile added this to the v2 milestone Nov 16, 2021
@david-novafacile
Copy link
Contributor

Will be fixed in v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants