Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trace commitment refactoring #77

Merged
merged 4 commits into from
Mar 30, 2022
Merged

Trace commitment refactoring #77

merged 4 commits into from
Mar 30, 2022

Conversation

irakliyk
Copy link
Collaborator

@irakliyk irakliyk commented Mar 17, 2022 •
edited
Loading

This PR refactors how we handle trace commitments in preparation for implementing RAPs (#54).

Specifically:

  • Breaks out building of trace and constraint commitments into separate functions of the Prover trait.
  • Introduces a Matrix struct which is used a backing type for trace and constraint evaluations.
  • Combine trace LDE and trace Merkle tree into TraceCommitment struct.

Jasleen1
Jasleen1 reviewed Mar 17, 2022
View reviewed changes
Copy link
Contributor

@Jasleen1 Jasleen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, we may want to rename or refractor some of the trace related operations, but otherwise, this looks great. Thank you!

@irakliyk irakliyk marked this pull request as ready for review March 20, 2022 07:32
Jasleen1
Jasleen1 approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@Jasleen1 Jasleen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you for working on this!

@Nashtare Nashtare mentioned this pull request Mar 24, 2022
Closed
@irakliyk irakliyk mentioned this pull request Mar 25, 2022
Merged
6 tasks
@irakliyk irakliyk merged commit 634ed73 into main Mar 30, 2022
@irakliyk irakliyk deleted the trace-commitment branch March 30, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jasleen1 Jasleen1 Jasleen1 approved these changes

@dbeaverfb dbeaverfb Awaiting requested review from dbeaverfb

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irakliyk @Jasleen1 @facebook-github-bot