Skip to content
This repository has been archived by the owner on Feb 11, 2022. It is now read-only.

PlayerFactory use a Builder #53

Closed
Mecharyry opened this issue Jun 26, 2017 · 2 comments
Closed

PlayerFactory use a Builder #53

Mecharyry opened this issue Jun 26, 2017 · 2 comments

Comments

@Mecharyry
Copy link
Contributor

Problem

Lot's of "discussions" around the PlayerFactory when adding the DOWNGRADE_SECURE_DECODER because we passed a boolean all the way down instead of having two different method signatures.

Potential Solution

Use the Builder pattern, it's ideal when you want to customise something.

Impact

Extensible and we can provide easily visible defaults.

@Mecharyry
Copy link
Contributor Author

Pass down MediaCodecSelector when doing this.

@ouchadam
Copy link
Contributor

fixed by #57

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants