Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract_feature input args bug in notebook Tutorial1 #14

Closed
sammaxwellxyz opened this issue Jun 5, 2020 · 2 comments
Closed

Extract_feature input args bug in notebook Tutorial1 #14

sammaxwellxyz opened this issue Jun 5, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@sammaxwellxyz
Copy link

The extract_features function in the 6th code cell is called with a features_list argument, i believe it be should a components_list argument.
@sammaxwellxyz sammaxwellxyz changed the title Extract_feature input args bug in notebook Tutorial Extract_feature input args bug in notebook Tutorial1 Jun 5, 2020
@rlenain
Copy link
Contributor

rlenain commented Jun 5, 2020

Hi there,
Thanks very much for flagging that, I'll go ahead and fix it.
In the future, feel free to raise a pull request :)

@rlenain rlenain added the bug Something isn't working label Jun 5, 2020
@rlenain
Copy link
Contributor

rlenain commented Jun 5, 2020

Fixed. Thanks for your contribution to Surfboard!

@rlenain rlenain closed this as completed Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sammaxwellxyz @rlenain