Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not pin dependency versions #9

Closed
jonashaag opened this issue May 27, 2020 · 2 comments
Closed

Do not pin dependency versions #9

jonashaag opened this issue May 27, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@jonashaag
Copy link

Pinning dependencies of a library to an exact version (e.g., pandas==1.0.1) has many drawbacks, for example security issues. I see no reason why the dependencies have to be pinned for surfboard.

Maybe we can pin only the major versions, e.g. pandas>=1,<2.
@rlenain
Copy link
Contributor

rlenain commented May 27, 2020

Thanks very much -- we'll consider this.

@rlenain rlenain added the enhancement New feature or request label May 28, 2020
@rlenain rlenain mentioned this issue Jun 2, 2020
Merged
@rlenain
Copy link
Contributor

rlenain commented Jun 2, 2020

Addressed in #13 . Thanks for the suggestion @jonashaag

@rlenain rlenain closed this as completed Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonashaag @rlenain