-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NV-1812] Webhook Provider #2958
Comments
Quick question regarding this feature (as it is something that can interest my company) : Our usecase is to use different smtp config (as we offer our client to setup their own smtp in our app) and because we can't override the provider in Novu atm, using websocket and handling this by ourselves would be an acceptable tradeoff. Do you need any external help on this feature request ? |
@jlucidar I think it will make to pass the actually rendered template, wdyt? What would be the usecase to pass the actually layout and raw template? Do you want to render it on your end aswell? |
We already have our own layout implementation at the moment, and it's not all the time statically generated. I think having an option on the provider might be a good solution. so users can switch between rendered html or raw template. Let me know if you want a PR for this :) |
@jlucidar I think we can even pass them both so the user can decide in runtime, wdyt? And yes, would really appreciate a PR for this! Let me know if you want to discuss some implementation details you had in mind |
Hi @scopsy , I opened a draft PR towards this issue. (#3244) At the moment only the webhook for the email channel is implemented. A few choice I made, but not sure if this is the way you intended to do it :
LEt me know how that work for you and I can then complete the PR for the other channels as necessary (SMS, Push ?, In app ?) |
Hi there Is there any plan to implement the SMS Webhook to implement the custom SMS providers by the companies? |
Why? (Context)
For companies that have legacy delivery systems, novu can trigger an API request with all the information related to the trigger to a webhook URL, the novu customer will be responsible for the actual delivery of the message.
What?
Implementing a new Webhook provider for each channel type novu has so that the content will still be managed on Novu's side, and instead of calling a provider such as SendGrid, we will perform an API call to the webhook.
Definition of Done
From SyncLinear.com | NV-1812
The text was updated successfully, but these errors were encountered: