Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: iframe nc width issue #3320

Merged
merged 1 commit into from
May 3, 2023
Merged

Conversation

BiswaViraj
Copy link
Contributor

What change does this PR introduce?

  • removed the media query code added recently. It was considering the width of the iframe instead of the window.
    Still not sure about the width increase behavior on hover/click.

Why was this change needed?

Other information (Screenshots)

Screen.Recording.2023-05-03.at.5.44.56.PM.mov

@BiswaViraj BiswaViraj self-assigned this May 3, 2023
@linear
Copy link

linear bot commented May 3, 2023

NV-2183 iframe NC width increase on hover

Why? (Context)

At first iframe NC loads in less width than other options (web-component, react, angular), and then when we hover over NC, it increases its width. after a certain width increase, it again comes to normal width.

What?

dd63f995-e060-4c3c-9e3e-60f0d973b92e

Definition of Done

@scopsy scopsy added this pull request to the merge queue May 3, 2023
Merged via the queue into next with commit f1ab32f May 3, 2023
28 checks passed
@scopsy scopsy deleted the nv-2183-iframe-nc-width-increase-on-hover branch May 3, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants